Bug 219149

Summary: multimedia/mythtv-frontend: Update to 0.28.1
Product: Ports & Packages Reporter: Walter Schwarzenfeld <w.schwarzenfeld>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: decke, jeffrey, miwi, rajil.s, robbak
Priority: --- Keywords: needs-qa, patch
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
svn-diff-multimedia_frontend
none
svn-diff-mythtv
none
svn-diff-mythtv-frontend
none
svn-diff-mythplugin-mythmusic
none
svn-diff-mythplugin-mythmusic_v2
none
svn-diff-mythplugin-mythmusic_v3
none
svn-diff-mythplugin-mythmusic_v4
none
svn-diff-mythtv_0314403
none
svn-diff-mythtv-frontend_0314403
none
svn-diff-mythtv_03f4403_v2
none
svn-diff-mythtv_frontend_03f4403_v2
none
svn-diff-audio_mythplugin-mythmusic_03f4403
none
mythplugin-mythmusich_poudriere.log
none
svn-diff-mythplugin-mythmusic_03f4403_v2
none
svn-diff-mythtv_03f4403_v3
none
Poudriere build fails
none
svn-diff-mythtv_03f4403_v4
none
svn-diff-mythtv_03f4403_v5
none
Log with failed build
none
mythtv.zip
none
WORK IN PROGRESS (HAS ISSUES) Patch against recent tree to build mythtv-frontend none

Description Walter Schwarzenfeld 2017-05-08 18:00:57 UTC
Created attachment 182413 [details]
svn-diff-multimedia_frontend

I made the update of mythtv in January. It was committed
two days ago. But I forget update mythtv-frontend too.
Comment 1 Walter Schwarzenfeld 2017-05-09 07:14:34 UTC
Testbuilds  with poudriere on 10.3amd64/i386 ok.
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2017-05-09 08:11:19 UTC
Hi,

Could u please have a look in to audio/mythplugin-mythmusic as well?
Comment 3 Walter Schwarzenfeld 2017-05-09 08:35:39 UTC
Separate PR or here?
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2017-05-09 09:32:58 UTC
Just add it here.
Comment 5 Walter Schwarzenfeld 2017-05-09 11:18:18 UTC
Did not find any plugin mythplugin-mythmusic version 0.28.7.
Problably we had to revert the update of mythtv (?).
Comment 6 Martin Wilke freebsd_committer freebsd_triage 2017-05-09 11:48:52 UTC
0.28.1 should do the trick. I tired to update that last time but i got a problem with the lib there...
Comment 7 Walter Schwarzenfeld 2017-05-09 11:51:12 UTC
Yes, In the moment I try update to 0.28.1 (all three ports).
Should I close here and make a new PR for 0.28.1?
(I made the error, cause the request in january was for 0.28.7 and I 
take that, and does not look for the right version).
Comment 8 Walter Schwarzenfeld 2017-05-09 12:00:45 UTC
Do you revert it ? Or should I make the svn-diff for mythtv from 0.28.7.
Comment 9 Martin Wilke freebsd_committer freebsd_triage 2017-05-09 12:53:31 UTC
Hi,

Just update here, i will take care of it.
Comment 10 Walter Schwarzenfeld 2017-05-09 13:18:06 UTC
Created attachment 182439 [details]
svn-diff-mythtv
Comment 11 Walter Schwarzenfeld 2017-05-09 13:18:47 UTC
Created attachment 182440 [details]
svn-diff-mythtv-frontend
Comment 12 Walter Schwarzenfeld 2017-05-09 13:26:36 UTC
Seems I can't work out audio/mythplugin-mythmusic.
Got different error messages. Seems a problem with DISTNAME.
For the moment I did not find a solution.
Comment 13 Walter Schwarzenfeld 2017-05-10 00:58:22 UTC
Created attachment 182459 [details]
svn-diff-mythplugin-mythmusic
Comment 14 Walter Schwarzenfeld 2017-05-10 16:30:33 UTC
Poudriere test build for all three ports with 10.3-amd64/i386 ok.
Comment 15 Walter Schwarzenfeld 2017-05-11 04:46:41 UTC
Created attachment 182499 [details]
svn-diff-mythplugin-mythmusic_v2

Had to change some things.
Found no way to solve the conflict with ffmpeg. So I
make a IGNORE statement.

Developer=on still states a error messag about shebangs.
But it is changed with the reinplace_cmd.
(Shebangfix at stage is not possible yet. Should come
with the new shebang.mk version).
Comment 16 Walter Schwarzenfeld 2017-05-11 05:02:53 UTC
Created attachment 182501 [details]
svn-diff-mythplugin-mythmusic_v3

Maybe, I done something wrong. Now it seems to work
with ffmpeg install. Removed IGNORE.
Comment 17 Walter Schwarzenfeld 2017-05-11 05:35:07 UTC
Created attachment 182503 [details]
svn-diff-mythplugin-mythmusic_v4

Version 4:
forgot adapt pkg-plist.
Removed CONFIGURE_ARGS. We don't need it, all is
enabled.

This should now be ok (I hope so).
Comment 18 Rajil Saraswat 2017-05-14 13:26:05 UTC
The mythtv file (MythTV-mythtv-v0.28.1-ad97d24_GH0.tar.gz) refers to a tag of ad97d24 which is the 0.27.5 tag at https://github.com/MythTV/mythtv/releases. The 0.28.1 tag is 03f4403.

Is this a 0.27.5 port or a 0.28.1 port?
Comment 19 Walter Schwarzenfeld 2017-05-14 13:41:52 UTC
You are right. I will make it new.
Comment 20 Walter Schwarzenfeld 2017-05-16 13:26:09 UTC
Created attachment 182636 [details]
svn-diff-mythtv_0314403
Comment 21 Walter Schwarzenfeld 2017-05-16 13:27:33 UTC
Created attachment 182638 [details]
svn-diff-mythtv-frontend_0314403
Comment 22 Walter Schwarzenfeld 2017-05-16 13:28:38 UTC
New version of the patches (the appended number is the tagnumber from git).
Comment 23 Walter Schwarzenfeld 2017-05-16 15:15:28 UTC
There is something goin badly wrong. Seems I damaged the working version.
So I had do it complete new..
Comment 24 Walter Schwarzenfeld 2017-05-18 20:54:31 UTC
Created attachment 182716 [details]
svn-diff-mythtv_03f4403_v2
Comment 25 Walter Schwarzenfeld 2017-05-18 23:38:40 UTC
Created attachment 182725 [details]
svn-diff-mythtv_frontend_03f4403_v2
Comment 26 Walter Schwarzenfeld 2017-05-19 00:37:02 UTC
Poudriere test builds ok on 103amd64/i386.
portlint ok, stage-qa, check-plist ok.
Only problem:
After start it states
QT mysql-driver not found.
So I had to install databases/qt5-sqldrivers-mysql (after this it starts
without problems). But I don't found the right syntax to add this 
to RUN_DEPENDS.
Comment 27 Walter Schwarzenfeld 2017-05-19 14:06:21 UTC
Created attachment 182739 [details]
svn-diff-audio_mythplugin-mythmusic_03f4403
Comment 28 Walter Schwarzenfeld 2017-05-19 16:15:42 UTC
mythplugin music has with poudriere an pkg-plist issue I don't understand.
Does not find file, which are definite there if I compile it in the port.
Seems it is something with PLIST_SUB=      MYTHSHARE="share/mythtv".
Comment 29 Walter Schwarzenfeld 2017-05-19 16:42:45 UTC
Created attachment 182742 [details]
mythplugin-mythmusich_poudriere.log
Comment 30 Walter Schwarzenfeld 2017-05-20 03:44:35 UTC
Created attachment 182752 [details]
svn-diff-mythplugin-mythmusic_03f4403_v2
Comment 31 Rajil Saraswat 2017-05-20 19:05:59 UTC
Please can you also build plugins/mythzoneminder.
Comment 32 Walter Schwarzenfeld 2017-05-20 21:24:39 UTC
From the last buildlog:
Configuration settings: 
 
        qmake          /usr/local/lib/qt5/bin/qmake
 
        MythArchive    plugin will be built
        MythBrowser    plugin will be built
        MythGallery    plugin will not be built
        MythGame       plugin will be built
        MythMusic      plugin will be built
        MythNetvision  plugin will be built
        MythNews       plugin will be built
        MythWeather    plugin will be built
=>        MythZoneMinder plugin will be built

ls -al /usr/local/lib/mythtv/plugins/libmythzoneminder.so 
-rwxr-xr-x  1 root  wheel  400080 20 Mai 23:16 /usr/local/lib/mythtv/plugins/libmythzoneminder.so

mythzmserver is there.

Is something missed or overlooked I something?
Comment 33 Rajil Saraswat 2017-05-21 01:45:31 UTC
Doesnt it make sense to do a diff against the files in the port tree i.e. 0.28.7 instead of 0.27.5.20150616?

At the moment mythtv doesnt patch cleanly against 0.28.7.
Comment 34 Walter Schwarzenfeld 2017-05-21 11:07:46 UTC
Created attachment 182773 [details]
svn-diff-mythtv_03f4403_v3
Comment 35 Walter Schwarzenfeld 2017-05-21 11:09:00 UTC
No, does not. Ok, this should now the correct svn diff.
Comment 36 Rajil Saraswat 2017-05-21 15:22:27 UTC
Created attachment 182777 [details]
Poudriere build fails

I patched my ports tree with the mythtv v3 patch, and it was clean. Unfortunately, it is refusing to build.
Comment 37 Walter Schwarzenfeld 2017-05-21 16:57:34 UTC
Created attachment 182780 [details]
svn-diff-mythtv_03f4403_v4
Comment 38 Walter Schwarzenfeld 2017-05-21 19:53:50 UTC
Created attachment 182783 [details]
svn-diff-mythtv_03f4403_v5

Sorry, run into problems with svn (caused some problems I 
wrote above).
Should now the right version.
Comment 39 Rajil Saraswat 2017-05-21 20:52:54 UTC
Created attachment 182785 [details]
Log with failed build

Tried building v5 but it failed.
Comment 40 Walter Schwarzenfeld 2017-05-21 23:44:23 UTC
Created attachment 182786 [details]
mythtv.zip
Comment 41 Walter Schwarzenfeld 2017-05-21 23:46:06 UTC
Svn make nonsense,
In the moment it is only possible to send you  the file from the mythtv port.
Comment 42 Walter Schwarzenfeld 2017-05-22 00:39:10 UTC
You can use svn-diff-mythtv_v5 if you remove after patching
in the directory files all files with size 0 and patch-libs__libmythtv__recorders__dvbstreamhandler.cpp
Comment 43 Walter Schwarzenfeld 2017-05-22 00:40:47 UTC
And remove for sure all *.orig files.
Comment 44 Walter Schwarzenfeld 2017-05-22 01:18:22 UTC
Also remove patch-libs__libmythdvdnav__dvdnav__dvdnav.c.
Comment 45 Rajil Saraswat 2017-05-22 01:19:22 UTC
The mythtv.zip builds fine.
Comment 46 Walter Schwarzenfeld 2017-05-22 01:43:09 UTC
Thanks for reply and for patience.
Comment 47 Rajil Saraswat 2017-05-22 02:14:00 UTC
(In reply to w.schwarzenfeld from comment #46)
All thanks to you for the port. Btw i dont see mythzmserver installed.

# pkg info --list mythtv | grep zm
        /usr/local/share/mythtv/themes/Terra/watermarks/zm_console.png
        /usr/local/share/mythtv/themes/Terra/watermarks/zm_events.png
        /usr/local/share/mythtv/themes/Terra/watermarks/zm_live.png
        /usr/local/share/mythtv/themes/default/locale/zm.png
Comment 48 Rajil Saraswat 2017-05-22 02:20:36 UTC
Is it possible to enable ivtv and hdpvr in the port?

Both drivers are part of webcamd.

# Input Support
Joystick menu             no
lirc support              yes
libCEC device support     no [/usr/include]
Video4Linux support       no
ivtv support              no
HD-PVR support            no
FireWire support          no
DVB support               no [/usr/src/linux-headers-11.0-RELEASE-p10/include/uapi]
DVB-S2 support            no
HDHomeRun support         yes
V@Box TV Gateway support  yes
Ceton support             yes
ASI support               no
Comment 49 Walter Schwarzenfeld 2017-05-22 03:55:02 UTC
mythtv/configure:
freebsd)
        append CCONFIG "freebsd"
        # Workaround compile errors from missing u_int/uint def
        CPPFLAGS=`echo $CPPFLAGS | sed 's/-D_POSIX_C_SOURCE=200112//'`
        disable ivtv
        disable v4l2
 =>       enable backend
        ;

if enabled backend; then
  echo "Video4Linux support       ${v4l2-no}"
=>  echo "ivtv support              ${ivtv-no}"
=>  echo "HD-PVR support            ${hdpvr-no}"
  echo "FireWire support          ${firewire-no}"
  echo "DVB support               ${dvb-no} [$dvb_path]"
  echo "DVB-S2 support            ${fe_can_2g_modulation-no}"
  echo "HDHomeRun support         ${hdhomerun-no}"
  echo "V@Box TV Gateway support  ${vbox-no}"
  echo "Ceton support             ${ceton-no}"
  echo "ASI support               ${asi-no}"
fi

----------
Maybe, it was a misunderstood, but I have enabled zoneminder in
mythplugin-mythmusic.
Comment 50 Walter Schwarzenfeld 2017-05-22 04:39:32 UTC
Zoneminder is also enabled in mythtv-frontend.
Comment 51 Walter Schwarzenfeld 2017-05-22 07:39:05 UTC
Was no missunderstood. Mythtv has no option and no entry in mythtv/configure
to enable zoneminder.
Comment 52 robbak 2017-06-21 12:13:36 UTC
What's happened to these ports? multimedia/mythtv is labelled 0.28.7, a version that doesn't even exist; mythtv-frontend is labelled 0.28.1; but both ports have the git tag for, and install, 0.27.5. The broken commits even have the same email address as these apparently correct patches.

What's going on?
Comment 53 Walter Schwarzenfeld 2017-06-21 12:21:36 UTC
0.28.7 was my error. I will be better this "update" to 0.28.7 should reversed,
till a new version is committed.
Comment 54 robbak 2017-06-21 12:30:49 UTC
(In reply to robbak from comment #52)
Um, the commit to mythtv-frontend updated the portversion, but updated nothing else. The update to mythtv included some changes, but left the all-important GH-TAGNAME untouched...!!???

From what I can see, the recent commits to these ports need to be reverted, and these patches applied.
Comment 55 Walter Schwarzenfeld 2017-06-21 12:43:51 UTC
Only mythtv needs to reverted.
Comment 56 robbak 2017-06-21 12:52:43 UTC
(In reply to w.schwarzenfeld from comment #55)
mythfrontend still needs to be updated. All the commit did is called it 0.28.1 - it didn't include any of your changes to actually update anything. It is still the old 0.27.5 port, and that's what it installs. 

Literally, the commit was just:

--- head/multimedia/mythtv-frontend/Makefile	2016/12/18 22:06:50	428889
+++ head/multimedia/mythtv-frontend/Makefile	2017/05/07 10:57:36	440322
@@ -2,8 +2,7 @@
 # $FreeBSD$
 
 PORTNAME=	mythtv-frontend
-PORTVERSION=	0.27.5.20150616
-PORTREVISION=	1
+PORTVERSION=	0.28.1
 CATEGORIES=	multimedia
 
 MAINTAINER=	ports@FreeBSD.org

That's it. The only other change was the distinfo - and that only changed the filename, as without changing the git tag, it's the same distribution. (Oh, and the hash is out of date anyway, as github has since respun the download)

Martin messed up the commit badly!
Comment 57 Mathieu Arnold freebsd_committer freebsd_triage 2017-07-06 13:52:43 UTC
Assignee timeout. Give back to the pool.
Comment 58 robbak 2017-07-22 01:23:34 UTC
Created attachment 184585 [details]
WORK IN PROGRESS (HAS ISSUES) Patch against recent tree to build mythtv-frontend

Here is my patch, just used to install mythtv-frontend. I have tested basic use - viewing live tv and recordings - but not the various plugins.

This builds and works, with the following caveats - it builds in poudriere, but it leaves lots of orphans. There is no included way to build only the frontend - the option was removed from the configure scripts years ago - so it builds the full backend, and just leaves them in the staging directory, to portlint's disgust. Secondly, I can't get it to build on my system outside of poudriere. I need to add -I${LOCALBASE}/include to CPPFLAGS so ./configure will find needed local libraries, but with that, it will use local libraries when it needs the bundled ones. I couldn't find a way around that, especially when it uses -isystem to do the bundled includes, as that is used after all other normal -I directories.

There are also a good number of other script files left in staging, that could be useful to a frontend.
Comment 59 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-23 11:58:58 UTC
Comment on attachment 184585 [details]
WORK IN PROGRESS (HAS ISSUES) Patch against recent tree to build mythtv-frontend

Patches that have known issues should probably not be submitted attached, but there is indeed value in having them there for others to obtain/test/improve upon. 

It should however, be made explicitly clear that they are not ready to commit
Comment 60 Walter Schwarzenfeld 2017-09-07 02:21:58 UTC
I think it is better to close here. In the meantime there existists a newer version 
of mythtv.
Comment 61 Mark Linimon freebsd_committer freebsd_triage 2017-09-09 17:03:58 UTC
Closed by submitter's request.
Comment 62 Rajil Saraswat 2017-09-09 17:14:40 UTC
(In reply to w.schwarzenfeld from comment #60)
Is there a port of mythtv-0.29 available?
Comment 63 robbak 2017-09-11 08:35:20 UTC
(In reply to Rajil Saraswat from comment #62)
No, there isn't. There isn't even a port of 0.28. Despite the portversion, this port installs the insecure version  0.27.5.