Bug 219175

Summary:

databases/py-peewee: Update to 2.10.1

Product:

Ports & Packages

Reporter:

Matthias Petermann <matthias>

Component:

Individual Port(s)

Assignee:

Yuri Victorovich <yuri>

Status:

Closed FIXED

Severity:

Affects Some People

CC:

adamw, dbaio, matthias, miwi, yuri

Priority:

---

Keywords:

patch

Version:

Latest

Flags:

matthias: maintainer-feedback+
matthias: merge-quarterly?

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
Patch file	none
Test results	none
Updated patch	none
Test results with cython option turned off	none
Test results with cython option turned on	none

Description Matthias Petermann 2017-05-10 00:06:53 UTC

Created attachment 182456 [details]
Patch file

Changes:	https://github.com/coleifer/peewee/releases

Comment 1 Matthias Petermann 2017-05-10 00:08:30 UTC

Created attachment 182457 [details]
Test results

Comment 2 Danilo G. Baio freebsd_committer

2017-05-11 02:41:59 UTC

Hi Matthias.

Is it worth create an additional option for build peewee with Cython? Could you take a look?


>=======================<phase: stage          >============================
>===>  Staging for py27-peewee-2.10.0
>===>   py27-peewee-2.10.0 depends on package: py27-setuptools>0 - found
>===>   py27-peewee-2.10.0 depends on file: /usr/local/bin/python2.7 - found
>===>   Generating temporary packing list
>setup.py:23: UserWarning: Cython C extensions for peewee will NOT be built, because >Cython does not seem to be installed. To enable Cython C extensions, install Cython >>=0.22.1.
>  'extensions, install Cython >=' + cython_min_version + '.')

https://github.com/coleifer/peewee/blob/master/setup.py#L14-L37

You can set maintainer-approval to + on attachments for ports you are MAINTAINER of.

Comment 3 Matthias Petermann 2017-05-13 16:49:47 UTC

Hi Danilo,

thanks for the proposal. I will check this weekend and likely update the port regardingly.

Best regards,
Matthias

Comment 4 Matthias Petermann 2017-05-23 22:07:10 UTC

Created attachment 182839 [details]
Updated patch

Comment 5 Matthias Petermann 2017-05-23 22:07:48 UTC

Created attachment 182840 [details]
Test results with cython option turned off

Comment 6 Matthias Petermann 2017-05-23 22:08:26 UTC

Created attachment 182841 [details]
Test results with cython option turned on

Comment 7 Matthias Petermann 2017-05-23 22:29:48 UTC

Please consider this PR temporary as "on hold". I just found out that I missed some cases for the post-install section (did the test with the default SQLITE, but PGSQL and MYSQL seem to use their dedicated native extensions). I will update the patch soon and add further comment.

Comment 8 Yuri Victorovich freebsd_committer

2018-03-05 08:06:05 UTC

Maintainer's timeout expired.

Comment 9 Yuri Victorovich freebsd_committer

2018-03-05 08:07:04 UTC

Update committed.

Comment 10 commit-hook freebsd_committer

2018-03-05 08:07:40 UTC

A commit references this bug:

Author: yuri
Date: Mon Mar  5 08:06:59 UTC 2018
New revision: 463624
URL: https://svnweb.freebsd.org/changeset/ports/463624

Log:
  databases/py-peewee: Update to 3.1.2

  Maintainer's timeout expired: matthias@petermann-it.de

  Port changes:
  * Changed to DISTVERSION
  * Removed option DOCS (not needed)
  * Added USES=localbase sqlite
  * Added USE_PYTHON=cython concurrent
  * Added stripping
  * Removed MYSQL_VARS

  PR:		219175
  Approved by:	tcberner (mentor, implicit)

Changes:
  head/databases/py-peewee/Makefile
  head/databases/py-peewee/distinfo