Bug 219270

Summary: [patch] sysutils/atop: fails to build on head after r315662
Product: Ports & Packages Reporter: Vladyslav Movchan <vladislav.movchan>
Component: Individual Port(s)Assignee: Mark Linimon <linimon>
Status: Closed FIXED    
Severity: Affects Some People CC: linimon, samm
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (samm)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Fix for post-r315662 none

Description Vladyslav Movchan 2017-05-14 04:26:31 UTC 
Created attachment 182580 [details]
Fix for post-r315662

sysutils/atop fails to compile after base r315662:
> --- photosyst.o ---
> photosyst.c:1596:11: error: no member named 'xt_tp' in 'struct xtcpcb'
>                 if (tp->xt_tp.t_state == TCPS_ESTABLISHED ||
>                     ~~  ^
> photosyst.c:1597:11: error: no member named 'xt_tp' in 'struct xtcpcb'
>                     tp->xt_tp.t_state == TCPS_CLOSE_WAIT)
>                     ~~  ^
> 2 errors generated.
> *** [photosyst.o] Error code 1

After "xt_tp.t_state" replaced with "t_state" port compiles but fails to run:
$ atop
atop: sysctl(vm.stats.vm.v_forkpages...) failed: Cannot allocate memory (12)
$

Attached patch fixes both problems
Comment 1 Oleksii Samorukov freebsd_committer freebsd_triage 2017-05-28 14:21:28 UTC 
Thank you for the patch, please commit, maintainer.
Comment 2 Vladyslav Movchan 2017-05-29 15:14:16 UTC 
I'm not a committer, so I can't do it myself.

PS It seems it is also safe to delete BROKEN_armv6=, BROKEN_mips=, BROKEN_mips64= and BROKEN_powerpc64= lines which were added recently into FreeBSD port Makefile.
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2017-06-26 00:43:21 UTC 
Committed, thanks.

I don't have a way to test on -current but it showed no regressions on 11.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-06-26 00:43:35 UTC 
A commit references this bug:

Author: linimon
Date: Mon Jun 26 00:42:53 UTC 2017
New revision: 444332
URL: https://svnweb.freebsd.org/changeset/ports/444332

Log:
  Attempt to fix build on -current.  Remove BROKEN_<arch> false positives.

  PR:		219270
  Submitted by:	vladislav.movchan@gmail.com
  Approved by:	maintainer

Changes:
  head/sysutils/atop/Makefile
  head/sysutils/atop/files/patch-photosyst.c