Bug 219289

Summary: security/clambc: fails to build with lang/gcc6 or later
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: dim, emaste, gerald, rene, toolchain, zi
Priority: --- Keywords: needs-patch, needs-qa
Version: LatestFlags: koobs: maintainer-feedback+
Hardware: Any   
OS: Any   

Description Jan Beich freebsd_committer freebsd_triage 2017-05-14 22:00:01 UTC
In file included from llvm/include/llvm/Support/Allocator.h:17:0,
                 from llvm/include/llvm/ADT/StringMap.h:18,
                 from llvm/include/llvm/System/Host.h:17,
                 from llvm/lib/System/Host.cpp:14:
llvm/include/llvm/Support/AlignOf.h:57:24: error: expected unqualified-id before 'alignof'
 static inline unsigned alignof() { return AlignOf<T>::Alignment; }
                        ^~~~~~~
In file included from llvm/include/llvm/System/Host.h:17:0,
                 from llvm/lib/System/Host.cpp:14:
llvm/include/llvm/ADT/StringMap.h: In static member function 'static llvm::StringMapEntry<ValueTy>* llvm::StringMapEntry<ValueTy>::Create(const char*, const char*, AllocatorTy&, InitType)':
llvm/include/llvm/ADT/StringMap.h:170:33: error: expected primary-expression before '<' token
     unsigned Alignment = alignof<StringMapEntry>();
                                 ^
llvm/include/llvm/ADT/StringMap.h:170:48: error: expected primary-expression before '>' token
     unsigned Alignment = alignof<StringMapEntry>();
                                                ^
llvm/include/llvm/ADT/StringMap.h:170:50: error: expected primary-expression before ')' token
     unsigned Alignment = alignof<StringMapEntry>();
                                                  ^

build log: http://sprunge.us/FOVh
Comment 1 Dimitry Andric freebsd_committer freebsd_triage 2017-05-14 22:18:07 UTC
Oof, the package is using a *very* old version of LLVM.  This problem was fixed upstream more than 6 years ago:

http://llvm.org/viewvc/llvm-project?view=revision&revision=117774
Comment 2 Gerald Pfeifer freebsd_committer freebsd_triage 2017-05-15 07:41:47 UTC
Should we then just deprecate and remove this port?  It appears we've
got way too much old cruft in the tree... :-(
Comment 3 Dimitry Andric freebsd_committer freebsd_triage 2017-05-15 08:39:43 UTC
Certainly, for a security product, it is a little strange they have not updated their backend libraries for 6 years.  I would not trust this, in any case. :)
Comment 4 Ryan Steinmetz freebsd_committer freebsd_triage 2017-05-15 13:27:30 UTC
If you are interested in maintaining the port, please feel free to take it.

I'm no longer an active user of this port.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2017-05-28 06:51:17 UTC
Reporter is committer and current maintainer appears "wont fix". Re-assign to reporter to take maintainership or deprecate, and resolve/close accordingly.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2017-05-28 06:51:37 UTC
Did not intend to close, revert.
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-08-12 14:52:35 UTC
A commit references this bug:

Author: gerald
Date: Sat Aug 12 14:51:38 UTC 2017
New revision: 447836
URL: https://svnweb.freebsd.org/changeset/ports/447836

Log:
  Mark deprecated with an expiration date of 2017-09-13 since this is
  essentially unmaintained upstream (last RC three years ago, features
  issues fixed on the clang side six years ago, and fails to build with
  modern compilers such GCC 6+ or clang for that matter).

  Reset maintainership to give others a chance to pick this up. [1]

  Bump PORTREVISION due to the changes above.

  Replace USE_GCC=any by USE_GCC=5 to unstall PR 219275.

  PR:		219289, 219275
  Approved by:	zi (maintainer) [1]

Changes:
  head/security/clambc/Makefile
Comment 8 Rene Ladan freebsd_committer freebsd_triage 2017-09-14 17:43:22 UTC
Expired port removed.