Bug 219293
| Summary: | science/massxpert: fails to build with lang/gcc6 or later | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jan Beich <jbeich> | ||||
| Component: | Individual Port(s) | Assignee: | Raphael Kubo da Costa <rakuco> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | gerald, rakuco, vg | ||||
| Priority: | --- | Flags: | rakuco:
maintainer-feedback-
rakuco: merge-quarterly+ |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 219275 | ||||||
| Attachments: |
|
||||||
Created attachment 184742 [details]
Proposed patch
The attached patch fixes the build with GCC 6; it also fixes an actual bug in that method which GCC was complaining about.
I've also dropped MAKE_JOBS_UNSAFE after building the port successfully with both -j2 and -j<big number>.
A commit references this bug: Author: rakuco Date: Sun Aug 13 11:19:53 UTC 2017 New revision: 447878 URL: https://svnweb.freebsd.org/changeset/ports/447878 Log: Add patch to drop a wrong ';' in an if check. In addition to fixing an actual bug, this also fixes the build with GCC 6: /wrkdirs/usr/ports/science/massxpert/work/massxpert-3.4.0/lib/propListHolder.cpp: In member function 'bool massXpert::PropListHolder::removeProp(const QString&)': /wrkdirs/usr/ports/science/massxpert/work/massxpert-3.4.0/lib/propListHolder.cpp:216:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation] if(m_propList.at(iter)->name() == name); ^~ /wrkdirs/usr/ports/science/massxpert/work/massxpert-3.4.0/lib/propListHolder.cpp:217:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' { PR: 219293 Approved by: maintainer timeout (vg, 18 days) MFH: 2017Q3 Changes: head/science/massxpert/Makefile head/science/massxpert/files/patch-lib_propListHolder.cpp A commit references this bug: Author: rakuco Date: Sun Aug 13 11:20:36 UTC 2017 New revision: 447879 URL: https://svnweb.freebsd.org/changeset/ports/447879 Log: Drop MAKE_JOBS_UNSAFE. Tentatively remove it after testing the port with -j2 and -jLOTS_OF_CORES. PR: 219293 Changes: head/science/massxpert/Makefile A commit references this bug: Author: rakuco Date: Thu Aug 17 16:28:15 UTC 2017 New revision: 448144 URL: https://svnweb.freebsd.org/changeset/ports/448144 Log: MFH: r447878 Add patch to drop a wrong ';' in an if check. In addition to fixing an actual bug, this also fixes the build with GCC 6: /wrkdirs/usr/ports/science/massxpert/work/massxpert-3.4.0/lib/propListHolder.cpp: In member function 'bool massXpert::PropListHolder::removeProp(const QString&)': /wrkdirs/usr/ports/science/massxpert/work/massxpert-3.4.0/lib/propListHolder.cpp:216:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation] if(m_propList.at(iter)->name() == name); ^~ /wrkdirs/usr/ports/science/massxpert/work/massxpert-3.4.0/lib/propListHolder.cpp:217:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' { PR: 219293 Approved by: maintainer timeout (vg, 18 days) Approved by: ports-secteam (feld) Changes: _U branches/2017Q3/ branches/2017Q3/science/massxpert/Makefile branches/2017Q3/science/massxpert/files/patch-lib_propListHolder.cpp A commit references this bug: Author: rakuco Date: Sat Aug 26 20:55:41 UTC 2017 New revision: 448784 URL: https://svnweb.freebsd.org/changeset/ports/448784 Log: Revert r447879. Apparently the build is indeed broken with parallel jobs, even though I wasn't able to reproduce it in my tests. Checking what's broken would take time and anyone interested in that should rather try updating the port to 3.6.0. PR: 219293 Reported by: John Marino <freebsdml@marino.st> Changes: head/science/massxpert/Makefile |
/wrkdirs/usr/ports/science/massxpert/work/massxpert-3.4.0/lib/propListHolder.cpp: In member function 'bool massXpert::PropListHolder::removeProp(const QString&)': /wrkdirs/usr/ports/science/massxpert/work/massxpert-3.4.0/lib/propListHolder.cpp:216:2: error: this 'if' clause does not guard... [-Werror=misleading-indentation] if(m_propList.at(iter)->name() == name); ^~ /wrkdirs/usr/ports/science/massxpert/work/massxpert-3.4.0/lib/propListHolder.cpp:217:2: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if' { ^ build log: http://sprunge.us/HhRA