Bug 219296

Summary: www/anyterm: fails to build with lang/gcc6 or later
Product: Ports & Packages Reporter: Jan Beich <jbeich>
Component: Individual Port(s)Assignee: Raphael Kubo da Costa <rakuco>
Status: Closed FIXED    
Severity: Affects Only Me CC: douglas, gerald, rakuco
Priority: --- Flags: douglas: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on:    
Bug Blocks: 219275    
Attachments:
Description Flags
Proposed patch douglas: maintainer-approval+

Description Jan Beich freebsd_committer 2017-05-14 22:28:25 UTC
In file included from ../src/Cell.hh:24:0,
                 from ../src/Terminal.hh:24,
                 from ../src/Terminal.cc:19:
../src/unicode.hh:33:17: error: redeclaration of C++ built-in type 'char32_t' [-fpermissive]
 typedef wchar_t char32_t;
                 ^~~~~~~~

build log: http://sprunge.us/OCig
Comment 1 Raphael Kubo da Costa freebsd_committer 2017-07-26 17:40:14 UTC
Created attachment 184744 [details]
Proposed patch

The attached patch forces the use of an older C++ standard to fix the build. Updating the port to a newer release would likely allow dropping this.
Comment 2 Douglas Thrift 2017-07-26 17:58:18 UTC
Comment on attachment 184744 [details]
Proposed patch

Looks fine to me. Thanks!
Comment 3 Gerald Pfeifer freebsd_committer 2017-07-26 20:02:21 UTC
Thanks, Raphael and thanks Douglas for the quick confirmation!


Douglas, based on Raphael's comment I had a look and checking
  http://svn.anyterm.org/anyterm/trunk/CHANGELOG
there are a number of changes related to C++ standards (and in 
fact GCC probably is not required any longer). If you'd like to
submit an update that might be good (independently of this PR).
Comment 4 commit-hook freebsd_committer 2017-07-26 21:45:38 UTC
A commit references this bug:

Author: rakuco
Date: Wed Jul 26 21:44:38 UTC 2017
New revision: 446699
URL: https://svnweb.freebsd.org/changeset/ports/446699

Log:
  Force an older C++ standard than C++11 to build.

  This fixes the build with GCC >= 6, which use C++11 by default. This version of
  anyterm is not compatible with C++11.

  PR:		219296
  Approved by:	Douglas Thrift <douglas@douglasthrift.net>

Changes:
  head/www/anyterm/Makefile