Bug 219412

Summary: security/snort2pfcd: Update to 2.0
Product: Ports & Packages Reporter: Samee Shahzada <onestsam>
Component: Individual Port(s)Assignee: Jochen Neumeister <joneum>
Status: Closed FIXED    
Severity: Affects Some People CC: joneum
Priority: --- Keywords: needs-qa
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Update patch onestsam: maintainer-approval+

Description Samee Shahzada 2017-05-20 06:43:44 UTC

    
Comment 1 Samee Shahzada 2017-05-20 06:44:36 UTC
Created attachment 182753 [details]
Update patch
Comment 2 Jochen Neumeister freebsd_committer freebsd_triage 2017-05-20 16:18:24 UTC
 % portlint -AC
FATAL: Makefile: [1]: incorrect header; use Created by: with a single space, then $FreeBSD$.
FATAL: Makefile: non-comment line in comment section.
FATAL: Makefile: no $FreeBSD$ line in comment section.
FATAL: Makefile: extra item "MAINTAINER" placed in the PORTNAME section.
FATAL: Makefile: extra item "COMMENT" placed in the PORTNAME section.
FATAL: Makefile: PORTNAME has to be there.
WARN: Makefile: PORTVERSION/DISTVERSION is set externally to this port's Makefile, but this port is not configured as a slave port.
WARN: Makefile: CATEGORIES is set externally to this port's Makefile, but this port is not configured as a slave port.
FATAL: Makefile: extra item "LICENSE" placed in the MAINTAINER section.
FATAL: Makefile: extra item "LICENSE_FILE" placed in the MAINTAINER section.
WARN: Makefile: COMMENT is set externally to this port's Makefile, but this port is not configured as a slave port.
FATAL: Makefile: extra item "LIB_DEPENDS" placed in the LICENSE section.
FATAL: Makefile: extra item "RUN_DEPENDS" placed in the LICENSE section.
FATAL: distinfo.orig: for safety, be sure to cleanup backup files before committing the port.
FATAL: Makefile.orig: for safety, be sure to cleanup backup files before committing the port.

Maintainer, cam you please fix this? Thanks
Comment 3 Samee Shahzada 2017-05-23 00:08:17 UTC
Thats really weird. Im wondering if you are using an old ports distribution or old version of portlint. Are your ports and portlint up to date?

Here is the makefile thats giving me "looks fine" with both portlint and portlint -AC

# $FreeBSD: head/security/snort2pfcd/Makefile 440742 2017-05-13 00:48:46Z dbaio $

PORTNAME=       snort2pfcd
PORTVERSION=    1.9.1
CATEGORIES=     security
MASTER_SITES=   http://www.tworoutes.com/oss/

MAINTAINER=     onestsam@gmail.com
COMMENT=        Snort alert to pf blocker

LICENSE=        GPLv2
LICENSE_FILE=   ${WRKSRC}/COPYING

LIB_DEPENDS=    libcidr.so:devel/libcidr
RUN_DEPENDS=    snort:security/snort

USE_RC_SUBR=    snort2pfcd
PLIST_FILES=    man/man8/snort2pfcd.8.gz \
                sbin/snort2pfcd

do-install:
        ${INSTALL_PROGRAM} ${WRKSRC}/snort2pfcd ${STAGEDIR}${PREFIX}/sbin
        ${INSTALL_MAN} ${WRKSRC}/snort2pfcd.8.gz ${STAGEDIR}${MAN8PREFIX}/man/man8

.include <bsd.port.mk>
Comment 4 Jochen Neumeister freebsd_committer freebsd_triage 2017-05-23 15:49:54 UTC
Hm, wired. I'll test it in poudriere, end when okay, commit it :-)
Comment 5 Jochen Neumeister freebsd_committer freebsd_triage 2017-05-23 21:55:29 UTC
Committed, thanks :-)