Bug 219511
| Summary: | graphics/graphviz: shebangfix for modgraph.py | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | John Hein <jcfyecrayz> | ||||||||
| Component: | Individual Port(s) | Assignee: | Dirk Meyer <dinoex> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | Flags: | dinoex:
maintainer-feedback+
|
||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 182874 [details]
[patch] [v2] shebangfix for .py
v2: for consistency use _VARS for ruby, etc., as well
The extensions in your patch look wrong, example: +RUBY_VARS= SHEBANG_FILES+=tclpkg/gv/demo/modgraph.py regression: IGNORE_WITH_PHP is lost. regression: tcl_CMD is lost, needed when TCL is implied by TK. This patch v2 will not be applied. Please test. Sorry about the copy/paste issue with the extensions. I have a new patch to fix that. It also adds back the IGNORE_WITH_PHP I inadvertently removed as well. I didn't make it conditional on OPTIONS_PHP since that would only be useful if PHP is on anyway, but it could be added to PHP_VARS. I don't understand 'regression: tcl_CMD is lost'. I built a fresh graphviz with poudriere testport and just selected the TK option (leaving all other options at their defaults). The shebang repair for modgraph.tcl seemed to work just fine. Note that the same tcl_CMD definition that is currently in graphviz/Makefile is in shebangfix.mk. Tested by: - poudriere testport with default options + TK, and 'head modgraph.tcl' to verify shebang fix (#!/usr/local /bin/tclsh8.6) - poudriere with PHP & php70 (modgraph.php has: #!/usr/local/bin/php) - stage-qa OK - check-orphans OK - portlint - no new warnings/errors Created attachment 183070 [details] [patch] [v3] shebangfix for .py Here's the patch mentioned in comment 3. It also includes a fix for PYTHON_LDFLAGS I've had for a while... PYTHON_LIBDIR has .py modules not linkable libraries. A commit references this bug: Author: dinoex Date: Tue May 30 19:49:33 UTC 2017 New revision: 442117 URL: https://svnweb.freebsd.org/changeset/ports/442117 Log: - use OPTION_VARS= SHEBANG_FILES+= - extend SHEBANG_FILES for modgraph.py - fix PYTHON_LDFLAGS - remove tcl workaround PR: 219511 Submitted by: John Hein - extend SHEBANG_FILES for modgraph.pl Changes: head/graphics/graphviz/Makefile Commited with changes. Thanks. |
Created attachment 182873 [details] [patch] shebangfix for .py stage-qa gives this if PYTHON is on: Error: '/usr/bin/python' is an invalid shebang you need USES=shebangfix for 'share/graphviz/demo/modgraph.py' Attached is a patch to fix that and remove tcl shebang stuff that is now in shebangfix.mk. Note this uses *_VARS option framework. Changing the PHP, RUBY, LUA, TCL SHEBANG_FILES settings the same way is not included in this patch (but probably should have been).