Summary: | science/vmd: Suggested changes: typo, dependencies, shebang, license | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||
Component: | Individual Port(s) | Assignee: | David Naylor <dbn> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Only Me | Flags: | bugzilla:
maintainer-feedback?
(dbn) |
||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Yuri Victorovich
2017-05-29 20:18:11 UTC
Created attachment 183544 [details]
Fixed for vmd
The attached patch fixes most of your comments, except for:
2) openbabel: I cannot find any reference in the source code that actually uses openbabel, thus I am skipping it as a dependency.
4) The license (in clause 2) explicitly requires that people get directed to their website to obtain a copy of the program (and thus implicitly that we cannot mirror nor distribute the program)
I need to compile test this patch on multiple versions of FreeBSD, then I'll commit it.
A commit references this bug: Author: dbn Date: Sun Jun 18 06:03:30 UTC 2017 New revision: 443820 URL: https://svnweb.freebsd.org/changeset/ports/443820 Log: science/vmd: various fixes - fix spelling of VMD license [1] - use USES=tcl,tk instead of direct dependency - patch vmd to support (tcl|tk)86 - fix shebang for tcl [1] - fix detection of netcdf - add sqlite as a dependency (for dmsplugin) [1] - add expact as a dependency (for hoomdplugin) - rework configuration: - explicitly list required components (CONFIGURE_ARGS) - call configure directly (instead of via gmake(1)) - patch configure to accept TCLLDFLAGS and TKLDFLAGS - pass PREFIX as an environment variable instead of using sed(1) - patch Make-arch to accept environment TCLLDFLAGS and NETCDFLDFLAGS - add support for parallel building (except for building plugins) - bump PORTREVISION PR: 219642 Reported by: Yuri Victorovich <yuri@rawbw.com> Changes: head/science/vmd/Makefile head/science/vmd/files/patch-Make-arch head/science/vmd/files/patch-configure head/science/vmd/pkg-plist Committed, thanks for reporting. tachyon-0.99b6.tar.gz doesn't fetch any more. I tried several times over 3 days. I can confirm it works for me (now): ===> License VMD BSD3CLAUSE STRIDE accepted by the user ===> vmd-1.9.3_3 depends on file: /usr/local/sbin/pkg - found => tachyon-0.99b6.tar.gz doesn't seem to exist in /usr/ports/distfiles/. => Attempting to fetch http://jedi.ks.uiuc.edu/~johns/raytracer/files/0.99b6/tachyon-0.99b6.tar.gz tachyon-0.99b6.tar.gz 100% of 2911 kB 49 kBps 00m59s ===> Fetching all distfiles required by vmd-1.9.3_3 for building => SHA256 Checksum OK for vmd-1.9.3.src.tar.gz. => SHA256 Checksum OK for tachyon-0.99b6.tar.gz. => SHA256 Checksum OK for stride.tar.gz. Can you visit the website http://jedi.ks.uiuc.edu/~johns/raytracer/files/0.99b6/? (In reply to David Naylor from comment #5) Yes, it fetches. > 2) openbabel: I cannot find any reference in the source code that actually uses openbabel, thus I am skipping it as a dependency. This line > molfile_plugin/src/babelplugin.c:711: babelbin = getenv("VMDBABELBIN"); actually uses the openbabel executable. But since this is only a runtime dependency from one of the plugins and through the environment variable, I think RUN_DEPENDS can be omitted in this case. |