Bug 219799
| Summary: | devel/tortoisehg: Update to 4.2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jeroen Ruigrok van der Werven <asmodai> | ||||
| Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||
| Status: | Closed Overcome By Events | ||||||
| Severity: | Affects Many People | CC: | arrowd | ||||
| Priority: | --- | Keywords: | needs-qa | ||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
(In reply to Jeroen Ruigrok van der Werven from comment #0) > Currently tortoisehg does not work since devel/mercurial got updated to 4.2. Yeah, that happens often, unfortunately. > This update corrects that. It also makes sure all the .pyo suffixes are taken care of, most were previously hardcoded. If you've made sure that building with NLS doesn't add any new translations to list in pkg-plist, then I'm OK with the patch. Thanks for working on this. I diff -ruN between 4.1.3 and 4.2 and didn't see any new translations or other files (or removals for that matter). Only thing I was not sure about was if I needed to add hgext3rd/__init__.py[co] since porttools' port test complained about it. Haven't put it through a poudriere test run with that change yet. (In reply to Jeroen Ruigrok van der Werven from comment #2) > I diff -ruN between 4.1.3 and 4.2 and didn't see any new translations or other files (or removals for that matter). Ok then. > Only thing I was not sure about was if I needed to add hgext3rd/__init__.py[co] since porttools' port test complained about it. Haven't put it through a poudriere test run with that change yet. Yep, these files are installed by mercurial itself. Reporter is committer, assign accordingly If ports approval is required (one only has a src or docs bit), please create a review on Phabricator and add the review to the URL field here. Once the chance is accepted you may commit the change. Alternatively have a ports committer you know approve the change here. Please also confirm the change passes QA (portlint, poudriere, etc) My doc/ports/src commit bit has been in safe keeping for the last 15 years. So I cannot commit it, nor am I up to date on the latest practices. @asmodai, You'll want to get poudriere up and running so that you can QA (using its testport command) ports changes, and ideally confirm successful QA of this change as well (if you can set it up in the short term) Will do a testport run tomorrow. Got it installed via a normal run already. ;) (In reply to Kubilay Kocak from comment #6) ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) ====>> Status for build devel/tortoisehg: package ====>> Checking for staging violations... done All went well with testport. This can be closed now: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220780 |
Created attachment 183236 [details] Update to 4.2 Currently tortoisehg does not work since devel/mercurial got updated to 4.2. This update corrects that. It also makes sure all the .pyo suffixes are taken care of, most were previously hardcoded.