Summary: | CONFIGURE_ENV do not take effect | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Jov <amutu> | ||||
Component: | Ports Framework | Assignee: | Port Management Team <portmgr> | ||||
Status: | Closed Not A Bug | ||||||
Severity: | Affects Only Me | CC: | ports-bugs | ||||
Priority: | --- | ||||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Jov
2017-06-06 03:24:27 UTC
There is no HAS_CONFIGURE, CONFIGURE, or CONFIGURE_ENV variable in the Makefile in the shar in that PR. Could you provide an example to reproduce the problem ? (In reply to Mathieu Arnold from comment #1) Hi ,please see this makefile to demonstrate the bug: https://bugs.freebsd.org/bugzilla/attachment.cgi?id=183252 yes,the original tensorflow shar file do not have HAS_CONFIGURE and CONFIGURE_ENV,because I use this: (cd ${WRKSRC} && PYTHON_BIN_PATH=${LOCALBASE}/bin/python TF_NEED_MKL=N \ CC_OPT_FLAGS="-march=native" TF_NEED_GCP=N TF_NEED_HDFS=N \ TF_ENABLE_XLA=N TF_NEED_OPENCL=N TF_NEED_CUDA=N \ PYTHON_LIB_PATH="${PYTHON_SITELIBDIR}" ./configure) and Kubilay Kocak review the pr and then give me advice to improve the configure target.I am trying to move the environment variables to CONFIGURE_ENV and find this bug. I do not see any bug here. CONFIGURE_ENV is not some kind of "magic" that happens to be added to the environment of the do-configure target. If you want it to work, you must not define do-configure yourself. See the definition of do-configure starting line 3111 of the current Mk/bsd.port.mk, and especially how CONFIGURE_CMD (./configure) is run between lines 3132 to 3140. |