Bug 219825

Summary: security/rkhunter: Remove www/wget dependency
Product: Ports & Packages Reporter: Helge Oldach <freebsd>
Component: Individual Port(s)Assignee: Richard Gallamore <ultima>
Status: Closed FIXED    
Severity: Affects Many People CC: freebsd, lukasz, ultima
Priority: --- Keywords: needs-qa
Version: LatestFlags: lukasz: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
diff -rN
koobs: maintainer-approval+
security/rkhunter.diff ultima: maintainer-approval? (lukasz)

Description Helge Oldach 2017-06-06 16:35:47 UTC 
rkhunter relies on wget to obtain updates. But it's not calling some esoteric wget invocation - wget is just used for straightforward downloads. Hence we might as well use fetch(1) which is bundled with the base system, relaxing on the wget dependency.

The attached rather trivial patch implements this.
Comment 1 Helge Oldach 2017-06-06 16:36:33 UTC 
Created attachment 183267 [details]
diff -rN
Comment 2 Lukasz Wasikowski 2017-06-07 08:23:08 UTC 
Comment on attachment 183267 [details]
diff -rN

Good idea, thank you for this patch.
Comment 3 Richard Gallamore freebsd_committer freebsd_triage 2017-06-13 18:21:30 UTC 
@Lucasz, the port has no arch-specific files, do I have approval to also add NO-ARCH=yes to the port?
Comment 4 Richard Gallamore freebsd_committer freebsd_triage 2017-06-13 21:02:17 UTC 
Created attachment 183461 [details]
security/rkhunter.diff

* Added NO_ARCH
* Fixed portlint items
Comment 5 Lukasz Wasikowski 2017-06-13 21:47:42 UTC 
(In reply to Richard Gallamore from comment #3)

Yes, thank you!
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-06-14 00:14:40 UTC 
A commit references this bug:

Author: ultima
Date: Wed Jun 14 00:14:22 UTC 2017
New revision: 443547
URL: https://svnweb.freebsd.org/changeset/ports/443547

Log:
  * Add fetch function to rkhunter
  * Remove wget as a dependency
  * Added NO_ARCH
  * Fixed portlint items

  PR:		219825
  Submitted by:	Helge Oldach <freebsd@oldach.net>
  Reviewed by:	matthew (mentor)
  Approved by:	Lukasz Wasikowski <lukasz@wasikowski.net> (maintainer), matthew (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11168

Changes:
  head/security/rkhunter/Makefile
  head/security/rkhunter/files/patch-files__rkhunter.conf
  head/security/rkhunter/files/patch-files_rkhunter
  head/security/rkhunter/files/patch-files_rkhunter.conf
  head/security/rkhunter/files/patch-installer.sh
  head/security/rkhunter/pkg-plist
Comment 7 Richard Gallamore freebsd_committer freebsd_triage 2017-06-14 00:17:18 UTC 
Committed, thanks!