Bug 219838
| Summary: | devel/bazel: Add CLANG38 option and make this port as a master port | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jov <amutu> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | Li-Wen Hsu <lwhsu> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Only Me | CC: | aehlig, amutu, lwhsu | ||||||||||||||
| Priority: | --- | Keywords: | needs-patch, needs-qa | ||||||||||||||
| Version: | Latest | Flags: | aehlig:
maintainer-feedback+
lwhsu: maintainer-feedback+ |
||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 219840 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 183288 [details]
bazel.diff
correct patch
I wasn't aware of the need of a slave port for devel/bazel (I only expected bazel to be added as a build dependency for other ports). But if there is the such a need, I'm happy to changing BUILD_DEPENDS= to BUILD_DEPENDS+=. I don't think, we need to bump the PORTREVISION though, as this port will still produce an identical bazel. (In reply to Klaus Aehlig from comment #2) Thanks for your reply! Yes,the PORTREVERSION need not bump. This is the slave port: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219840 Created attachment 183316 [details]
bazel_no_bump_version
patch without bump version
I believe ?= might be better in (this) the parent port, allowing complete (=) or partial (+=) override in the slave port. @Jov, please also obsolete old/outdated versions of any patches. You can do this by Attachment -> Details -> Edit Details -> [x] Obsolete. You can also obsolete older patches during the attachment of a new patch. (In reply to Kubilay Kocak from comment #5) Thanks Kubilay, Thank you for your remind, usually I do obsolete the old patch. V3 patch use '?=' instead of '+=' Created attachment 183320 [details]
bazel_v3.diff
Is this can be committed? Per this :https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219840#c4, this PR is not needed.Thanks everyone! After discussing with Klaus and Lwshu, reopen this to make clang38 as a option. Created attachment 184497 [details]
bazel-clang38-options.diff
1.add clang38 option,default off
2.add patch to get rid of /proc fs when build cpp. this already accepted by upstream, can be removed next version.
3.add conflict_install with slave port bazel-clang38.
Ask maintainer approval for the latest patch. Created attachment 184809 [details]
patch to devel/bazel to add CLANG38 option and update to 0.5.3
In the mean time, bazel 0.5.3 has been released which upstream already contains the patch to src/main/cpp/blaze_util_freebsd.cc. So I suggest to update to this version while adding the CLANG38 option.
(In reply to Klaus Aehlig from comment #13) Klaus, are you working on it right now? I'm about to process this patch next week. It's ok for me to wait your patch, but updating it twice is also fine. (In reply to Li-Wen Hsu from comment #14) The patch I uploaded (Attachment #184809 [details]) contains both to, adding the CLANG38 option, as well as the update to 0.5.3. Feel free to use it directly. A commit references this bug: Author: lwhsu Date: Sat Jul 29 06:38:32 UTC 2017 New revision: 446868 URL: https://svnweb.freebsd.org/changeset/ports/446868 Log: - Update to 0.5.3 [1] - Add CLANG38 option [2] PR: 219838 Submitted by: Jov <amutu@amutu.com> [2] Approved by: Klaus Aehlig <aehlig@linta.de> (maintainer) [1] Changes: head/devel/bazel/Makefile head/devel/bazel/distinfo head/devel/bazel/files/patch-src_main_java_com_google_devtools_build_lib_bazel_rules_python_python__stub__template.txt head/devel/bazel/files/patch-src_main_java_com_google_devtools_build_lib_bazel_rules_python_stub__template.txt Thanks Li Wen and Klaus! |
Created attachment 183287 [details] bazel.diff I am working on a slave port for bazel,it needs to add more dependence.Or I will copy and modify the whole Makefile of devel/bazel，It is ugly.