Bug 21991

Summary: ENABLE_SUIDPERL not documented in make.conf of -STABLE
Product: Base System Reporter: Andre Albsmeier <Andre.Albsmeier>
Component: confAssignee: Mark Murray <markm>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.1.1-STABLE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Andre Albsmeier 2000-10-14 19:20:00 UTC 
The installation of suidperl is now controlled with ENABLE_SUIDPERL
and not NOSUIDPERL.

Fix: This, or something similar...
How-To-Repeat: 
vi /usr/src/gnu/usr.bin/perl/suidperl/Makefile
Comment 1 Johan Karlsson freebsd_committer freebsd_triage 2000-10-14 22:45:46 UTC 
Responsible Changed
From-To: freebsd-bugs->markm

Over to perl maintainer.
Comment 2 hmo 2000-10-26 05:24:48 UTC 
>   Fix
>          
>This, or something similar...
>
>--- etc/defaults/make.conf.ORI  Sat Oct 14 20:10:25 2000
>+++ etc/defaults/make.conf      Sat Oct 14 20:12:52 2000
>@@ -71,7 +71,7 @@
> #NOPERL=       true    # To avoid building perl
> #NOPROFILE=    true    # Avoid compiling profiled libraries
> #NOSECURE=     true    # do not build crypto code in secure/ subdir
>-#NOSUIDPERL=   true    # To avoid building the suid perl
>+#ENABLE_SUIDPERL=true  # Turn setuid bit on for suidperl
> #NOSHARE=      true    # do not go into the share subdir
> #NOUUCP=       true    # do not build uucp related programs
> #
>

This should be fixed in src/gnu/usr.bin/perl/suidperl/Makefile to keep
the naming of options consistent:

--- src/gnu/usr.bin/perl/suidperl/Makefile.ORIG	Thu Oct  5 20:56:16 2000
+++ src/gnu/usr.bin/perl/suidperl/Makefile	Thu Oct 26 06:18:43 2000
@@ -13,10 +13,10 @@
 LINKS=	${BINDIR}/${PROG} ${BINDIR}/sperl5 \
 	${BINDIR}/${PROG} ${BINDIR}/sperl${VERSION}
 BINOWN=	root
-.if defined(ENABLE_SUIDPERL) && ${ENABLE_SUIDPERL} == "true"
-BINMODE=4511
-.else
+.if defined(NOSUIDPERL) && ${NOSUIDPERL} == "true"
 BINMODE=511
+.else
+BINMODE=4511
 .endif
 
 CLEANFILES=	Config.pm perlmain.c \

Greetings,
Helge
Comment 3 ru freebsd_committer freebsd_triage 2000-11-10 10:42:19 UTC 
State Changed
From-To: open->closed

Fixed in src/etc/defaults/make.conf,v 1.97.2.25.