Summary: | security/hashcat: build fails if libiconv port installed | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | John Hein <jcfyecrayz> | ||||||
Component: | Individual Port(s) | Assignee: | Nikolai Lifanov <lifanov> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | Flags: | bugzilla:
maintainer-feedback?
(lifanov) |
||||||
Priority: | --- | ||||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
John Hein
2017-06-12 11:12:44 UTC
Created attachment 183422 [details]
[patch] try to force including base iconv.h in case /usr/local/include/iconv.h exists
This possible patch forces /usr/include to be searched before /usr/local/include. Thus /usr/include/iconv.h will be found before /usr/local/include/iconv.h and the references to libiconv_* symbols becomes iconv_* (satisfied by /usr/lib/libiconv.so that is in all supported OS versions - i.e., basically 10.x+ now).
Created attachment 183427 [details]
[patch] add USES=iconv
This patch adds USES=iconv instead. I think this is better than forcing /usr/include before /usr/local/include.
This will have the effect of adding converters/libiconv to BUILD_DEPENDS if converters/libiconv is installed due to the current Uses/iconv.mk. But that's just a BUILD_DEPEND (can be removed after build), and I think Uses/iconv.mk could be altered to not force that BUILD_DEPEND addition (separate patch sent to tijl@).
I like the USES=iconv approach. Let me test a couple of things and I'll get it in. A commit references this bug: Author: lifanov Date: Mon Jun 12 21:53:05 UTC 2017 New revision: 443471 URL: https://svnweb.freebsd.org/changeset/ports/443471 Log: fix build with libiconv installed by USES=iconv PR: 219937 Submitted by: John Hein <z7dr6ut7gs@snkmail.com> Changes: head/security/hashcat/Makefile Committed, thanks! |