Bug 219944
| Summary: | [patch] USE_GNOME= glib20:build doesn't work | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Harald Schmalzbauer <bugzilla.freebsd> | ||||||||
| Component: | Ports Framework | Assignee: | freebsd-gnome (Nobody) <gnome> | ||||||||
| Status: | Closed Overcome By Events | ||||||||||
| Severity: | Affects Some People | CC: | portmgr, ports-bugs, tcberner | ||||||||
| Priority: | --- | Keywords: | patch | ||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Comment on attachment 183437 [details]
Add glib20_BUILD_DEPENDS definition.
This is no longer working, since comp_DETECT was removed in r457964.
I'll attach a updated version, which make USE GNOME=glib20:build work.
Created attachment 191776 [details]
Add glib20_BUILD_DEPENDS definition.
Moin moin You're missing a $. mfg Tobias Created attachment 191777 [details]
Add glib20_BUILD_DEPENDS definition.
Thanks, Tobias, sorry for the botchy post! New attachmant is corrected.
We don't want to encourage static libs for security reasons, so I think we should reject this patch. I agree with antoine, the trend is to remove all the STATIC options. Moin moin Please re-open if this is still an issue. mfg Tobias |
Created attachment 183437 [details] Add glib20_BUILD_DEPENDS definition. Trying to reduce superfluous dependencies, one might include STATIC option. In that case, devel/glib20 might be needed during build only. If you incorporate USE_GNOME and conditionally set it to glib20 or glib20:build, the latter would result in a build-depends-list (BUILD_DEPENDS) which is missing devel/glib20. There's no check which prevents the usage of glib20:build, and adhoc I couldn't find a good reason for which it should be disallowed, but I'm not familar with USE_* and gnome at all. The attached patch makes USE_GNOME=glib20:build working. Something similar is needed probably for more components!