Bug 220031

Summary: www/rt44: Add security patches from BestPractical
Product: Ports & Packages Reporter: Matthew Seaman <matthew>
Component: Individual Port(s)Assignee: Matthew Seaman <matthew>
Status: Closed FIXED    
Severity: Affects Many People CC: mikael, ports-secteam
Priority: Normal Keywords: needs-patch, needs-qa, security
Version: LatestFlags: bugzilla: maintainer-feedback? (mikael)
koobs: merge-quarterly?
Hardware: Any   
OS: Any   
URL: http://lists.bestpractical.com/pipermail/rt-announce/2017-June/000297.html
Attachments:
Description Flags
add security patches
koobs: maintainer-approval-
add security patches matthew: maintainer-approval?

Description Matthew Seaman freebsd_committer freebsd_triage 2017-06-16 07:38:23 UTC
Created attachment 183520 [details]
add security patches

Add security patches supplied by BestPractical in lieu of the next release of rrt44.

See: http://lists.bestpractical.com/pipermail/rt-announce/\
2017-June/000297.html

This needs to be MFH'd to 2017Q2 also.
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2017-06-16 08:28:40 UTC
patch-config.layout was changed and now /usr/local is hardcoded, is that intentional?
portrevision was not bumped.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2017-06-16 09:57:22 UTC
@Mikael, please set maintainer-approval flag (on attachment) to - if you would like to not accept existing or request changes. This ensures easy to see maintainer approval (or not) without looking through comments.
Comment 3 Matthew Seaman freebsd_committer freebsd_triage 2017-06-16 11:18:35 UTC
(In reply to mikael.urankar from comment #1)

Ah, yes.  You are correct.  That is unintended.  Let me fix that.
Comment 4 Matthew Seaman freebsd_committer freebsd_triage 2017-06-16 11:21:20 UTC
Created attachment 183526 [details]
add security patches

Don't override the %%PREFIX%% token expansion in patch-config.layout
Comment 5 Mikael Urankar freebsd_committer freebsd_triage 2017-06-16 12:03:15 UTC
Can you bump portrevision please?
Comment 6 Mikael Urankar freebsd_committer freebsd_triage 2017-06-16 12:06:04 UTC
Comment on attachment 183526 [details]
add security patches

PORTREVISION=   2 please
Comment 7 Mikael Urankar freebsd_committer freebsd_triage 2017-06-16 12:07:23 UTC
looks like I'm too dumb to set the maintainer-approval flag, so:
maintainer-approval = -
Comment 8 Mikael Urankar freebsd_committer freebsd_triage 2017-06-16 12:10:43 UTC
I won't be available in the next days, you have my approval to commit the patch when portrevision is bumped.
thanks.
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-06-16 14:26:45 UTC
A commit references this bug:

Author: matthew
Date: Fri Jun 16 14:26:12 UTC 2017
New revision: 443703
URL: https://svnweb.freebsd.org/changeset/ports/443703

Log:
  Add security patches from BestPractical in lieu of the upcoming 4.4.2
  release.

  See: http://lists.bestpractical.com/pipermail/rt-announce/\
  2017-June/000297.html

  PR:		220031
  Approved by:	mikael.urankar@gmail.com (maintainer)
  MFH:		2017Q2
  Security:	7a92e958-5207-11e7-8d7c-6805ca0b3d42

Changes:
  head/www/rt44/Makefile
  head/www/rt44/files/patch-Makefile.in
  head/www/rt44/files/patch-configure
  head/www/rt44/files/patch-lib_RT.pm
  head/www/rt44/files/patch-lib_RT_Authen_ExternalAuth_DBI.pm
  head/www/rt44/files/patch-lib_RT_Config.pm
  head/www/rt44/files/patch-lib_RT_Interface_Web.pm
  head/www/rt44/files/patch-lib_RT_User.pm
  head/www/rt44/files/patch-lib_RT_Util.pm
  head/www/rt44/files/patch-sbin_rt-test-dependencies
  head/www/rt44/files/patch-share_html_Dashboards_Subscription.html
  head/www/rt44/files/patch-share_html_Ticket_Attachment_dhandler
Comment 10 Matthew Seaman freebsd_committer freebsd_triage 2017-06-16 14:33:13 UTC
PORTREVISION set to 2 as noted.
Comment 11 commit-hook freebsd_committer freebsd_triage 2017-06-17 10:46:39 UTC
A commit references this bug:

Author: matthew
Date: Sat Jun 17 10:46:16 UTC 2017
New revision: 443767
URL: https://svnweb.freebsd.org/changeset/ports/443767

Log:
  MFH: r443703

  Add security patches from BestPractical in lieu of the upcoming 4.4.2
  release.

  See: http://lists.bestpractical.com/pipermail/rt-announce/\
  2017-June/000297.html

  PR:		220031
  Approved by:	mikael.urankar@gmail.com (maintainer)
  Security:	7a92e958-5207-11e7-8d7c-6805ca0b3d42

  Approved by:	portmgr (miwi)

Changes:
_U  branches/2017Q2/
  branches/2017Q2/www/rt44/Makefile
  branches/2017Q2/www/rt44/files/patch-Makefile.in
  branches/2017Q2/www/rt44/files/patch-configure
  branches/2017Q2/www/rt44/files/patch-lib_RT.pm
  branches/2017Q2/www/rt44/files/patch-lib_RT_Authen_ExternalAuth_DBI.pm
  branches/2017Q2/www/rt44/files/patch-lib_RT_Config.pm
  branches/2017Q2/www/rt44/files/patch-lib_RT_Interface_Web.pm
  branches/2017Q2/www/rt44/files/patch-lib_RT_User.pm
  branches/2017Q2/www/rt44/files/patch-lib_RT_Util.pm
  branches/2017Q2/www/rt44/files/patch-sbin_rt-test-dependencies
  branches/2017Q2/www/rt44/files/patch-share_html_Dashboards_Subscription.html
  branches/2017Q2/www/rt44/files/patch-share_html_Ticket_Attachment_dhandler
Comment 12 Matthew Seaman freebsd_committer freebsd_triage 2017-06-17 10:49:47 UTC
Commmitted, thanks!