Bug 220054
| Summary: | Mk/bsd.java.mk: Use POSIX-compliant regular expressions with grep(1) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Kyle Evans <kevans> | ||||||||
| Component: | Ports Framework | Assignee: | Kyle Evans <kevans> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | emaste, frebsd-java, glarkin, glewis, java, portmgr, ports-bugs, sgk | ||||||||
| Priority: | --- | Flags: | koobs:
maintainer-feedback?
(java) koobs: exp-run+ |
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 218385 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 183826 [details]
diff -U10 of bsd.java.mk; potentially improved
Alternatively, I propose the attached patch that cleans up the *_REGEXP generation a little bit by properly using make(1) logic *and* uses EREs instead of BREs. I double-checked that the generated patterns remained the same (spoilers: they did).
Created attachment 184305 [details]
svn(1) diff for exp-run
Redo the patch, svn(1) diff from base of the ports tree to be applied for the exp-run, for simplicity sake.
Exp-run looks fine. Reporter is committer, assign accordingly. Not sure who's (currently) on java@, but portmgr@ can also approve A commit references this bug: Author: kevans Date: Fri Jul 14 18:09:11 UTC 2017 New revision: 445802 URL: https://svnweb.freebsd.org/changeset/ports/445802 Log: Minor cleanup to Java version/vendor/OS validation - Use POSIX compliant expressions instead of employing GNU extensions (branching in BREs) - Simplify regex generation using make(1)'s :ts modifier PR: 220054 Approved by: bapt (portmgr) Changes: head/Mk/bsd.java.mk Thanks! |
Created attachment 183541 [details] svn(1) diff of Mk/bsd.java.mk Noted by Steve Kargl on freebsd-ports@: bsd.java.mk uses GNU extensions (branching BREs) for version/vendor validation, and bsdgrep(1) has not yet regrown GNU extensions. I'm attaching a patch to go ahead and make these expressions POSIX compliant.