Bug 220106

Summary: games/xscavenger [patch] fix fontmapping (already reported to upstream)
Product: Ports & Packages Reporter: Yasuhito FUTATSUKI <freebsd-bug-report-yf>
Component: Individual Port(s)Assignee: Jan Beich <jbeich>
Status: Closed FIXED    
Severity: Affects Some People Keywords: patch
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch against x.c, to place as files/patch-x.c none

Description Yasuhito FUTATSUKI 2017-06-18 11:49:58 UTC
Created attachment 183599 [details]
patch against x.c, to place as files/patch-x.c

As FreeBSD has switched compiler from Gcc to Clang, old potential bug caused by "definition of implementation" order of evaluation has revealed.

In the xscavenger comiled by Clang, characters of user name, and some menu cannot display correct letter font, because of incorrect font mapping.

The patch attached here is fix it.

(I also repoted to the author, and it will fixed if new version is released)
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-06-26 22:50:58 UTC
A commit references this bug:

Author: jbeich
Date: Mon Jun 26 22:49:54 UTC 2017
New revision: 444423
URL: https://svnweb.freebsd.org/changeset/ports/444423

Log:
  games/xscavenger: fix font mapping with Clang or GCC 7.*

  Characters of user name and some menu couldn't display the correct
  letters because of incorrect font mapping.

  PR:		220106
  Submitted by:	Yasuhito FUTATSUKI
  MFH:		2017Q2

Changes:
  head/games/xscavenger/Makefile
  head/games/xscavenger/files/patch-x.c
Comment 2 Jan Beich freebsd_committer freebsd_triage 2017-06-26 22:51:33 UTC
Thank you. Landed.

> As FreeBSD has switched compiler from Gcc to Clang, old potential
> bug caused by "definition of implementation" order of evaluation has
> revealed.

Builds using CC=gcc7 (from lang/gcc7-devel) were also affected.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-06-28 02:55:56 UTC
A commit references this bug:

Author: jbeich
Date: Wed Jun 28 02:55:48 UTC 2017
New revision: 444536
URL: https://svnweb.freebsd.org/changeset/ports/444536

Log:
  MFH: r444423

  games/xscavenger: fix font mapping with Clang or GCC 7.*

  Characters of user name and some menu couldn't display the correct
  letters because of incorrect font mapping.

  PR:		220106
  Submitted by:	Yasuhito FUTATSUKI
  Approved by:	ports-secteam (miwi)

Changes:
_U  branches/2017Q2/
  branches/2017Q2/games/xscavenger/Makefile
  branches/2017Q2/games/xscavenger/files/patch-x.c