Bug 220113
| Summary: | sysutils/qjail [Maintainer update] qjail-5.3 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Joe Barbish <qjail1> | ||||
| Component: | Individual Port(s) | Assignee: | Adam Weinberger <adamw> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | adamw | ||||
| Priority: | --- | Flags: | qjail1:
merge-quarterly?
|
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
|
Description
Joe Barbish
2017-06-18 15:44:01 UTC
Hi Joe, There's no patch attached here. Is it just a version bump, or would you like to attach a patch? Created attachment 183610 [details]
qjail-5.3_port_diff
A commit references this bug: Author: adamw Date: Mon Jun 19 02:04:25 UTC 2017 New revision: 443856 URL: https://svnweb.freebsd.org/changeset/ports/443856 Log: Update to 5.3 qjail-5.3-change-log 1. Adam Weinberger sent email about bug he found. The qjail console -c "ls /user/local" jailname command was not working correctly. This error was introduced by changes done to correct coding syntax problems that the hs-shellcheck package found and published in qjail-5.2. Fixed now. 2. Adam Weinberger also sent email containing a patch that standardized error messages and corrected some spelling errors. After review the patch was applied. 3. Checked all the 'kill' messages for 'Error:' prefix and added the prefix where it was missing to complete the standardization. 4. While reviewing the patch changes I noticed that the "qjail install" logic had some duplicated code. I removed it to make more of it part of the fall through logic path. 5. While working on the "qjail install" logic, 11.1-BETA1 was published. It cam to my attention that BETA and RC Release Engineering builds are now having distribution files built. Changed the 'qjail install' logic to auto handle BETA, RC, builds in the same manner RELEASE, and RELEASE-p builds were being handled. 6. Corrected the qjail manual to reflect the changes made to the script. PR: 220113 Submitted by: maintainer (Joe Barbish) MFH: 2017Q2 Changes: head/sysutils/qjail/Makefile head/sysutils/qjail/distinfo Sorry about the delay, Joe. Usually I try to commit PRs much faster than this, but Father's Day had me pretty tied up. This patch is committed, and I'm leaving the PR open pending the MFH. Same problem here with Father's Day. That's why I missed attaching the port make file patch when I created the PR. Thank you for committing this PR. Joe A commit references this bug: Author: adamw Date: Mon Jun 19 21:07:12 UTC 2017 New revision: 443910 URL: https://svnweb.freebsd.org/changeset/ports/443910 Log: MFH: r443856 Approved by: ports-secteam (zi) Update to 5.3 qjail-5.3-change-log 1. Adam Weinberger sent email about bug he found. The qjail console -c "ls /user/local" jailname command was not working correctly. This error was introduced by changes done to correct coding syntax problems that the hs-shellcheck package found and published in qjail-5.2. Fixed now. 2. Adam Weinberger also sent email containing a patch that standardized error messages and corrected some spelling errors. After review the patch was applied. 3. Checked all the 'kill' messages for 'Error:' prefix and added the prefix where it was missing to complete the standardization. 4. While reviewing the patch changes I noticed that the "qjail install" logic had some duplicated code. I removed it to make more of it part of the fall through logic path. 5. While working on the "qjail install" logic, 11.1-BETA1 was published. It cam to my attention that BETA and RC Release Engineering builds are now having distribution files built. Changed the 'qjail install' logic to auto handle BETA, RC, builds in the same manner RELEASE, and RELEASE-p builds were being handled. 6. Corrected the qjail manual to reflect the changes made to the script. PR: 220113 Submitted by: maintainer (Joe Barbish) Changes: _U branches/2017Q2/ branches/2017Q2/sysutils/qjail/Makefile branches/2017Q2/sysutils/qjail/distinfo MFH complete. Thanks, Joe. |
