Bug 220154

Summary: net-im/py-slackclient: Update to 1.0.6
Product: Ports & Packages Reporter: Jimmy Olgeni <olgeni>
Component: Individual Port(s)Assignee: Jimmy Olgeni <olgeni>
Status: Closed FIXED    
Severity: Affects Only Me CC: koobs
Priority: --- Flags: koobs: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Update patch
none
Update patch (with make test) koobs: maintainer-approval+

Description Jimmy Olgeni freebsd_committer freebsd_triage 2017-06-20 10:24:59 UTC 
Created attachment 183646 [details]
Update patch

Update net-im/py-slackclient to 1.0.6.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-06-20 11:05:00 UTC 
Thank you Jimmy. 

Did this change pass QA? (poudriere, maketest) ?

If so, change accepted (approved)
Comment 2 Jimmy Olgeni freebsd_committer freebsd_triage 2017-06-26 05:13:53 UTC 
(In reply to Kubilay Kocak from comment #1)

Hold on - I have a tiny change incoming, with a new port attached :)
Comment 3 Jimmy Olgeni freebsd_committer freebsd_triage 2017-06-26 10:35:45 UTC 
Created attachment 183804 [details]
Update patch (with make test)
Comment 4 Jimmy Olgeni freebsd_committer freebsd_triage 2017-06-26 10:37:24 UTC 
Tests would pass if you had pytest-mock installed somewhere - now everything works from 'make test' too. Poudriere still happy :)
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2017-06-26 11:03:54 UTC 
Comment on attachment 183804 [details]
Update patch (with make test)

@Olgeni If i don't feel like testing all test requirements and they all dont exist in the tree, I normally still just run the tests letting setuptools install the dependencies (since they should be in setup.py:tests_require). I must have missed pytest-mock :)

Looks good to go, thank you for the update
Comment 6 Jimmy Olgeni freebsd_committer freebsd_triage 2017-06-26 11:05:57 UTC 
(In reply to Kubilay Kocak from comment #5)

pytest-mock was actually introduced lately - that's why you missed it :)
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-06-26 12:40:57 UTC 
A commit references this bug:

Author: olgeni
Date: Mon Jun 26 12:40:20 UTC 2017
New revision: 444365
URL: https://svnweb.freebsd.org/changeset/ports/444365

Log:
  Update net-im/py-slackclient to version 1.0.6.

  PR:		220154
  Submitted by:	olgeni
  Approved by:	maintainer

Changes:
  head/net-im/py-slackclient/Makefile
  head/net-im/py-slackclient/distinfo
Comment 8 Jimmy Olgeni freebsd_committer freebsd_triage 2017-06-26 12:50:39 UTC 
Patch committed.