Bug 220205
| Summary: | [MAINTAINER-UPDATE] dns/knot2: upgrade to 2.5.1 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Leo Vandewoestijne <freebsd> | ||||||||
| Component: | Individual Port(s) | Assignee: | Matthew Seaman <matthew> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | freebsd, matthew | ||||||||
| Priority: | --- | ||||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Submitted the not-entirely-perfect patch... One second please. Created attachment 183702 [details]
update - knot 2.5.1
This is the correct patch I intended to submit.
(In reply to Leo Vandewoestijne from comment #1) Hi, Leo, Yes, I can see there are some issues with the patch as it stands. I haven't had a chance to look at in detail, but here's some things that leapt out at me: * Some tabs seem to have turned into spaces. That's not good in a Makefile * You've got both 'USES+=autoreconf' and a pre-configure target doing autoreconf too. You should only have the USES bit there. * You should USE shebangfix rather than your files/patch-src_utils_pykeymgr_pykeymgr.in Also, does this *really* have to use python3? The ports default is still python2.7 and it would be helpful to allow that to be used if possible. If not, then you need to add a dependency on python3 Created attachment 183705 [details]
Updated patch
This removes the surplus pre-configure target for running autoreconf -- you get that automatically with 'USES autoreconf'
Remove files/patch-src_utils_pykeymgr_pykeymgr.in and instead add
SHEBANG_FILES= src/utils/pykeymgr.in
Note: this will set the python interpreter to whatever is the default version
set by the user, typically /usr/local/bin/python2.7 -- judging by comments in that file, python2 seems to be supported. If it really needs python 3.x then you need something like: 'USES+=python:3.3+' which will do the right thing with the shebangfix automatically.
Clean up various tabs vs spaces and other punctuation issues.
I also note in my testing that knot2 will apparently build without errors on FreeBSD 10.3-RELEASE i386 but I don't know if it will work correctly there.
Hi, Leo, Let me know if you're happy with the changes I made or if there's anything else you want done differently. Otherwise I'll commit this over the weekend. Comment on attachment 183705 [details] Updated patch > note in my testing that knot2 will apparently build without errors on FreeBSD 10.3-RELEASE i386 > I'm happy to hear I'm not the only one who witnessed this. However, I receive the build-failure alert emails, that point to logs like: http://beefy10.nyi.freebsd.org/data/110i386-default/444089/logs/knot2-2.4.3.log which shows the same I now see in my own poudriere also, but didn't get the moment when doing previous update. Neither I didn't receive any negative feedback of i386 users. Can you tell me what compiler yours used? - if there's anything else you want done differently Your patch is fine. Thanks. Please commit. Earlier today 2.5.2 already came out, with very minor changes. I will use that one to adjust, such that there can be a metaport for libknot only, which knot-resolver requires. A commit references this bug: Author: matthew Date: Fri Jun 23 15:36:52 UTC 2017 New revision: 444181 URL: https://svnweb.freebsd.org/changeset/ports/444181 Log: Update to 2.5.1 * Add new USES: autoreconf, localbase, python, shebangfix * Mark broken on i386 -- undefined reference to '__atomic_fetch_add_8' * Move libfstrm.so dependency so it is only added when the DNSTAP option is enabled. PR: 220205 Submitted by: freebsd@dns-lab.com (maintainer) Changes: head/dns/knot2/Makefile head/dns/knot2/distinfo head/dns/knot2/files/pkg-message.in head/dns/knot2/pkg-plist Committed, thanks! My compile tests were, I believe, just using the system default clang on 10.3-RELEASE, but cached via CCACHE, all done via 'poudriere testport' Feel free to ping me when you have your 2.5.2 update ready to go. |
Created attachment 183699 [details] knot update to 2.5.1 Recently a new release of knot2 with nice updates. Meanwhile it turned out the port doesn't build anymore on i386 platforms due to atomic issues. I tried my best to solve that, but I unfortunately had to mark it being broken for i386. I'm convinced it's possible somehow, but am not enough of a C programmer to find a solution (and other than poudriere I also had no place to play around easily). So if anyone sees what's missing for i386, then please let me know.