Bug 220305
| Summary: | databases/py-odbc: Update to 4.0.17, Rename to databases/py-pyodbc | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Robert Kruus <rob.kruus> | ||||
| Component: | Individual Port(s) | Assignee: | Danilo G. Baio <dbaio> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | dbaio, rob.kruus | ||||
| Priority: | --- | Keywords: | needs-qa | ||||
| Version: | Latest | Flags: | dbaio:
maintainer-feedback+
|
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://reviews.freebsd.org/D11587 | ||||||
| Attachments: |
|
||||||
Oh, as an aside, the port name should probably be changed to py-pyodbc to match the pypi naming. I've submitted this for review with a few changes: - Switch to USES=localbase and remove a patch that does the same - STRIP pyodbc.so Let me know if you agree. Regards. (In reply to Danilo G. Baio from comment #2) Both changes mentioned are Approved by: portmgr (blanket, infrastructure) and don't require maintainer approval. Also, setup.py doesnt mention setuptools in any *_requires, so can be removed as a BUILD_DEPENDS (additionally, but not an unconditional reason: python.mk adds setuptools already as a BUILD/RUN dependency) Further, when adding a review to a bug, obsolete the patches (attachments), OR (more work) keep the attachments up to date. There should only ever be one (obvious) authoritative source of a changeset. Obsoleted attachments are not deleted, so they can be viewed by anyone in the future if necessary. I am OK with any changes you suggest. I am certainly no ports guru -- I just know enough to be dangerous. Comment on attachment 183841 [details] Patch to Makefile, distinfo and patch file New patch in review D11587 A commit references this bug: Author: dbaio Date: Tue Jul 18 23:40:22 UTC 2017 New revision: 446179 URL: https://svnweb.freebsd.org/changeset/ports/446179 Log: databases/py-odbc: Update to 4.0.17, Rename to databases/py-pyodbc Rename to comply with PyPI scheme While here: - Switch to USES=localbase and remove a patch that does the same - STRIP pyodbc.so PR: 220305 Submitted by: rob.kruus@gmail.com (maintainer) Approved by: garga (mentor) Differential Revision: https://reviews.freebsd.org/D11587 Changes: head/MOVED head/databases/Makefile head/databases/py-odbc/ head/databases/py-pyodbc/ head/databases/py-pyodbc/Makefile head/databases/py-pyodbc/distinfo head/databases/py-pyodbc/files/ Committed, thanks. A commit references this bug: Author: dbaio Date: Fri Jul 28 00:04:54 UTC 2017 New revision: 50593 URL: https://svnweb.freebsd.org/changeset/doc/50593 Log: Add Robert Kruus to contributors Maintainer of: databases/py-pyodbc devel/py-tzlocal PR: 220305 Changes: head/en_US.ISO8859-1/articles/contributors/contrib.additional.xml |
Created attachment 183841 [details] Patch to Makefile, distinfo and patch file Update the port to the latest version and fix the tabs that snuck into the patch file.