Bug 220308

Summary: security/sssd Python 2 hangs calling pysss.getgrouplist()
Product: Ports & Packages Reporter: amendlik
Component: Individual Port(s)Assignee: Rene Ladan <rene>
Status: Closed Overcome By Events    
Severity: Affects Some People CC: amendlik, kbowling, lukas.slebodnik, rene, timur, w.schwarzenfeld
Priority: --- Keywords: needs-qa
Version: LatestFlags: lukas.slebodnik: maintainer-feedback-
koobs: merge-quarterly?
Hardware: Any   
OS: Any   
URL: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org/message/6FPKQF5PTRW3RRIJMQ6XCMD32NY4BR4W/
Bug Depends on:    
Bug Blocks: 240708    
Attachments:
Description Flags
linked patch none

Description amendlik 2017-06-27 17:15:47 UTC 
Calls to SaltStack pysss.getgrouplist() send Python 2 into an infinite loop.

A patch for this issue was suggested in 2015 by Martin Andersen, but it does not appear to have been added upstream or to the FreeBSD port.
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org/thread/VAQK7VJUNTVOI6XYDZXFCZHZKXU3GYCA/

I have tested this patch and it does resolve the issue. I would suggest it be added to the security/sssd port.
Comment 1 Kevin Bowling freebsd_committer freebsd_triage 2017-06-28 05:56:23 UTC 
Created attachment 183872 [details]
linked patch

Adding the patch from the mailing list here for easier review
Comment 2 lukas.slebodnik 2017-07-05 16:33:38 UTC 
(In reply to amendlik from comment #0)
>Calls to SaltStack pysss.getgrouplist() send Python 2 into an infinite loop.

>A patch for this issue was suggested in 2015 by Martin Andersen, but it does not >appear to have been added upstream or to the FreeBSD port.
>https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org/thread/VAQK7VJUNTVOI6XYDZXFCZHZKXU3GYCA/

I can see a request for change.
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org/message/6FPKQF5PTRW3RRIJMQ6XCMD32NY4BR4W/

I would prefer upstream first approach.
Comment 3 amendlik 2017-07-06 19:03:59 UTC 
I agree that an upstream patch is preferable, but this bug does not seem to affect Linux. I have the same software stack and SSSD configuration running fine on CentOS.
There may be some difference in the results from the underlying system calls that require different handling on FreeBSD.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-07 06:14:06 UTC 
+1 on requesting upstream merge of this change
Comment 5 lukas.slebodnik 2018-02-25 16:06:52 UTC 
(In reply to amendlik from comment #0)
>Calls to SaltStack pysss.getgrouplist() send Python 2 into an infinite loop.
>
>A patch for this issue was suggested in 2015 by Martin Andersen, but it does >not appear to have been added upstream or to the FreeBSD port.
>https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org/thread/VAQK7VJUNTVOI6XYDZXFCZHZKXU3GYCA/
>
>I have tested this patch and it does resolve the issue. I would suggest it be added to the security/sssd port.

Would you mind to send patch to upstream as PR.
Most of upstream development occurs on github nowadays.
https://github.com/SSSD/sssd/
Comment 6 Walter Schwarzenfeld freebsd_triage 2018-05-31 01:27:46 UTC 
last version on https://releases.pagure.org/SSSD/sssd/ :

sssd-1.16.1.tar.gz	2018-03-09 12:08 	5.7M
Comment 7 Walter Schwarzenfeld freebsd_triage 2018-09-03 18:58:04 UTC 
in the meantime there is version 2.0.0.
https://releases.pagure.org/SSSD/sssd/sssd-2.0.0.tar.gz
Comment 8 Rene Ladan freebsd_committer freebsd_triage 2020-11-08 11:59:03 UTC 
Does this problem still happen with sssd 1.16 ?
Comment 9 Rene Ladan freebsd_committer freebsd_triage 2020-11-17 20:51:05 UTC 
Given that sssd no longer uses Python 2 as of r555585 where it has been updated to version 1.16.5, close this PR.