Bug 220397

Summary: mail/dovecot2: Fix NOTIFY broken since 2.2.31
Product: Ports & Packages Reporter: VK <vlad-fbsd>
Component: Individual Port(s)Assignee: Adam Weinberger <adamw>
Status: Closed FIXED    
Severity: Affects Some People CC: adamw
Priority: --- Keywords: patch, regression
Version: LatestFlags: bugzilla: maintainer-feedback? (adamw)
Hardware: Any   
OS: Any   
URL: https://dovecot.org/pipermail/dovecot/2017-June/108474.html
Attachments:
Description Flags
Dovecot2 NOTIFY fix vlad-fbsd: maintainer-approval? (adamw)

Description VK 2017-06-30 21:45:46 UTC 
Created attachment 183967 [details]
Dovecot2 NOTIFY fix

In version 2.2.31, NOTIFY command was broken due to misrepresented RFC. This patch applies the fix from upstream, as well as some additional error checking for NOTIFY parameter parsing.

Relevant ML thread:

* https://dovecot.org/pipermail/dovecot/2017-June/108474.html

NOTIFY fix:

* https://github.com/dovecot/core/commit/bcb321bc62117d30bc53a872ca1154c0100aeefd

Additional error checks:

* https://github.com/dovecot/core/commit/8b2d740b8182c63b76ff7ef0dd5e01710228705a

Also bump PORTREVISION for dovecot2-pigeonhole and dovecot2-antispam-plugin.

Builds with Poudriere on 11.1-BETA3, 11.0, amd64. Running in production now.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-06-30 22:57:06 UTC 
A commit references this bug:

Author: adamw
Date: Fri Jun 30 22:56:04 UTC 2017
New revision: 444810
URL: https://svnweb.freebsd.org/changeset/ports/444810

Log:
  Add upstream patches to fix IMAP NOTIFY subscriptions, broken in 2.2.31.

  PR:		220397
  Submitted by:	Vladimir Krstulja

Changes:
  head/mail/dovecot2/Makefile
  head/mail/dovecot2/files/patch-UPSTREAM-notify
Comment 2 Adam Weinberger freebsd_committer freebsd_triage 2017-06-30 22:59:17 UTC 
Committed, thanks for this, Vladimir!