Bug 22045
| Summary: | Some files should be modified since global was moved into ports. | ||
|---|---|---|---|
| Product: | Base System | Reporter: | shigio <shigio> |
| Component: | bin | Assignee: | David E. O'Brien <obrien> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | shigio |
| Priority: | Normal | ||
| Version: | Unspecified | ||
| Hardware: | Any | ||
| OS: | Any | ||
Responsible Changed From-To: freebsd-bugs->obrien David has removed the global(1) and friends from the src tree. State Changed From-To: open->closed I don't think we should remove global support as it is still useful. We have just moved the location and build methoid for it. People can pkg_add global and enjoy the nvi and build framework support for it. |
Since global was moved into ports, some files in core FreeBSD should be modified. Fix: I don't know what to do but can point out the locations. ------------------------------------------------------------------- [src/usr.bin/vi/Makefile] ------------------------------------------------------------------- o This line enables global support for nvi. I don't know whether or not we should remove this line but removing this line generate original nvi without global support. CFLAGS+= -DGTAGS ------------------------------------------------------------------- [src/share/mk/bsd.prog.mk] ------------------------------------------------------------------- o The following lines should be modified to fit ctags(1): It seems that NOTAGS macro is not used currently. .if defined(NOTAGS) tags: .endif .if !target(tags) tags: ${SRCS} _SUBDIR .if defined(PROG) @cd ${.CURDIR} && gtags ${GTAGSFLAGS} ${.OBJDIR} .if defined(HTML) @cd ${.CURDIR} && htags ${HTAGSFLAGS} -d ${.OBJDIR} ${.OBJDIR} .endif .endif .endif ------------------------------------------------------------------- [src/share/mk/bsd.dep.mk] ------------------------------------------------------------------- o This comment should be modified. # tags: # Create a (GLOBAL) gtags file for the source files. # If HTML is defined, htags is also run after gtags. o The following lines should be modified to fit ctags(1): It seems that NOTAGS macro is not used currently. .if defined(NOTAGS) tags: .endif .if !target(tags) tags: ${SRCS} _SUBDIR @cd ${.CURDIR} && gtags ${GTAGSFLAGS} ${.OBJDIR} .if defined(HTML) @cd ${.CURDIR} && htags ${HTAGSFLAGS} -d ${.OBJDIR} ${.OBJDIR} .endif .endif o '${.OBJDIR}/GPATH ${.OBJDIR}/GRTAGS ${.OBJDIR}/GSYMS ${.OBJDIR}/GTAGS should be removed. The code about HTML should be removed. Gtags(1) generates GPATH, GTAGS, GRTAGS and GSYMS. Htags(1) generates HTML directory. .if !target(cleandepend) cleandepend: _SUBDIR .if defined(SRCS) rm -f ${DEPENDFILE} ${.OBJDIR}/GPATH ${.OBJDIR}/GRTAGS \ ${.OBJDIR}/GSYMS ${.OBJDIR}/GTAGS .if defined(HTML) rm -rf ${.OBJDIR}/HTML .endif .endif .endif ------------------------------------------------------------------- [src/share/mk/sys.mk] ------------------------------------------------------------------- o The following lines should be removed. These definitions means parameter for gtags(1) and htags(1). # For tags rule. GTAGSFLAGS= -o HTAGSFLAGS= ------------------------------------------------------------------- [src/usr.bin/more/] ------------------------------------------------------------------- Since the more(1) which includes global support was replaced with less(1), thers is nothing to do about more. How-To-Repeat: N/A