Bug 220474
| Summary: | mail/spamassassin unescaped left brace in regex, lib/perl5/site_perl/Mail/SpamAssassin/PerMsgStatus.pm line 921 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Trond Endrestøl <Trond.Endrestol> | ||||||
| Component: | Individual Port(s) | Assignee: | Niclas Zeising <zeising> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | freebsd-2024 | ||||||
| Priority: | --- | Keywords: | easy, needs-qa, patch-ready | ||||||
| Version: | Latest | Flags: | zeising:
maintainer-feedback-
koobs: merge-quarterly? |
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| URL: | https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404 | ||||||||
| Attachments: |
|
||||||||
@Trond Thank you for your report & patch. Have it been submitted upstream? If so, please include the issue/pr link in the URL field (In reply to Kubilay Kocak from comment #1) I reported it now. See the URL field for details. Hi! Looking at the conversation from spamassassin's bugzilla, I found another patch instead. I've applied it to our port, can you please test. Regards! Created attachment 184279 [details] patch from spamassassin bugzilla. Updated patch, originally from spamassassin bugzilla: https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404 https://svn.apache.org/viewvc?view=revision&revision=1791013 (In reply to Niclas Zeising from comment #4) I have applied the patch on a running system and restarted sa-spamd. No warnings this time, but I'll wait another 24 hours and see if the patch has any effect, positive or negative. (In reply to Trond.Endrestol from comment #5) My 24 hours are up, and I see no unwanted side effects. I recommend the patch go live unless you need more testing. To follow the existing convention in the port, the new patch file should be called "patch-bug7404" -- after the upstream's bug: https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7404 Inside the file I would've removed the string ".orig" -- the five characters convey no information whatsoever. zeising, are you planning to commit this some time soon? I'm not sure it's great to rename the patch, then there's two patches touching the same file, I'm trying to use the FreeBSD ports tree naming convention. I'll try to get this in asap. (In reply to Niclas Zeising from comment #8) Local convention -- within a port -- trumps global convention. Generally, the "one patch per file" may be too simplistic a principle -- some times patches are grouped by the bug they are fixing or the feature they are adding. This allows to just point the upstream authors to the patch. Also, when the problem is addressed upstream, the single file can be removed. And if such grouping ends up touching the same file more than once -- so be it, it is not automatically bad... A commit references this bug: Author: zeising Date: Wed Aug 9 19:30:59 UTC 2017 New revision: 447641 URL: https://svnweb.freebsd.org/changeset/ports/447641 Log: Fix runtime on recent perl versions and change default options Add a patch from upstream to fix runtime when using perl 5.26 or later. [0] Change default options to include DKIM and SPF checking. Bump portrevision. PR: 220474 (based on) [0] Reported by: Trond.Endrestol@ximalas.info [0] Changes: head/japanese/spamassassin/Makefile head/mail/spamassassin/Makefile head/mail/spamassassin/files/patch-bug7404 Committed. Thanks for the patience! |
Created attachment 184066 [details] Patch for lib/perl5/site_perl/Mail/SpamAssassin/PerMsgStatus.pm post-Perl 5.26 After upgrading Perl to 5.26, it started to complain whenever mail/spamassassin is being run: Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.30), passed through in regex; marked by <-- HERE in m/^(.{ <-- HERE ,200}).*$/ at /usr/local/lib/perl5/site_perl/Mail/SpamAssassin/PerMsgStatus.pm line 921. Patch attached.