Bug 220546

Summary: [patch] zfs.ko: undefined reference to abd_is_linear(), abd_copy_to_buf() and (probably) others with ASSERT's enabled
Product: Base System Reporter: Andriy Voskoboinyk <avos>
Component: kernAssignee: freebsd-fs (Nobody) <fs>
Status: Closed FIXED    
Severity: Affects Some People CC: avg
Priority: --- Keywords: patch
Version: CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Add 'static' keyword to inline functions in abd.h none

Description Andriy Voskoboinyk freebsd_committer freebsd_triage 2017-07-07 19:49:16 UTC
These functions are used inside assertions; an example:

ASSERT(abd_is_linear(abd));

They declared in headers as 'inline'd; probably, they should be staticized as well.
Comment 1 Andriy Voskoboinyk freebsd_committer freebsd_triage 2017-07-08 11:14:23 UTC
Created attachment 184171 [details]
Add 'static' keyword to inline functions in abd.h

I think this was (also) caused by 'CFLAGS=-O0'; anyway, the patch fixes this issue for me.
Comment 2 Andriy Voskoboinyk freebsd_committer freebsd_triage 2017-08-20 12:35:25 UTC
Committed in r322601.