Bug 220613

Summary: devel/pcre: Update to 8.42
Product: Ports & Packages Reporter: Adam Weinberger <adamw>
Component: Individual Port(s)Assignee: Kirill Ponomarev <krion>
Status: Closed FIXED    
Severity: Affects Only Me Flags: adamw: exp-run?
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
8.41
none
8.42
none
8.42 + patches
none
monotone patch none

Description Adam Weinberger freebsd_committer 2017-07-10 21:28:04 UTC
Created attachment 184242 [details]
8.41
Comment 1 Adam Weinberger freebsd_committer 2017-07-10 21:28:48 UTC
Requesting exp-run to update devel/pcre to 8.41
Comment 2 Antoine Brodin freebsd_committer 2017-07-11 20:20:20 UTC
New failures on 11.0 amd64:

+ {"origin"=>"databases/mongodb32", "phase"=>"build", "errortype"=>"bad_C++_code"}
+ {"origin"=>"databases/mongodb34", "phase"=>"build", "errortype"=>"bad_C++_code"}
+ {"origin"=>"lang/racket", "phase"=>"stage", "errortype"=>"???"}
+ {"origin"=>"multimedia/kodi", "phase"=>"build", "errortype"=>"clang"}

New failure logs:

http://package18.nyi.freebsd.org/data/110amd64-default-PR220613/2017-07-11_19h51m33s/logs/errors/mongodb32-3.2.11.log
http://package18.nyi.freebsd.org/data/110amd64-default-PR220613/2017-07-11_19h51m33s/logs/errors/mongodb34-3.4.6.log
http://package18.nyi.freebsd.org/data/110amd64-default-PR220613/2017-07-11_19h51m33s/logs/errors/racket-6.9.log
http://package18.nyi.freebsd.org/data/110amd64-default-PR220613/2017-07-11_19h51m33s/logs/errors/kodi-17.1_2.log
Comment 3 Antoine Brodin freebsd_committer 2017-07-12 07:55:43 UTC
The racket failure may be unrelated (stack_guard)
Comment 4 Antoine Brodin freebsd_committer 2017-07-13 18:59:08 UTC
On 10.3 amd64 the new failures are the same:

+ {"origin"=>"databases/mongodb32", "phase"=>"build", "errortype"=>"bad_C++_code"}
+ {"origin"=>"databases/mongodb34", "phase"=>"build", "errortype"=>"bad_C++_code"}
+ {"origin"=>"multimedia/kodi", "phase"=>"build", "errortype"=>"clang"}

Failure logs:

http://package18.nyi.freebsd.org/data/103amd64-default-PR220613/2017-07-13_13h43m50s/logs/errors/mongodb32-3.2.11.log
http://package18.nyi.freebsd.org/data/103amd64-default-PR220613/2017-07-13_13h43m50s/logs/errors/mongodb34-3.4.6.log
http://package18.nyi.freebsd.org/data/103amd64-default-PR220613/2017-07-13_13h43m50s/logs/errors/kodi-17.3.log
Comment 5 Adam Weinberger freebsd_committer 2018-03-21 13:25:59 UTC
Created attachment 191703 [details]
8.42
Comment 6 Adam Weinberger freebsd_committer 2018-03-21 13:28:25 UTC
Can we please do an exp-run with this new patch, which updates pcre to 8.42?

The two older mongodb ports will still fail, but mongodb is a real pain to update, and the maintainers for them have failed to respond for over half a year now. I'll be creating a pcre840 port for them when 8.42 lands.
Comment 7 Antoine Brodin freebsd_committer 2018-03-25 19:21:37 UTC
A note before the exp-run : for the mongodb failures,  some patches like this on may help

https://github.com/mongodb/mongo/commit/218a7b1d4ea3d3b04a5f6f54c66640b3a15586b0
Comment 8 Antoine Brodin freebsd_committer 2018-03-25 19:25:27 UTC
And if the maintainer doesn't want to fix it,  I prefer to mark it BROKEN than to add another pcre port.
Comment 9 Adam Weinberger freebsd_committer 2018-03-26 20:13:52 UTC
Created attachment 191849 [details]
8.42 + patches

8.42, plus fixes for mongodb32, mongodb34, and opencollada
Comment 10 Antoine Brodin freebsd_committer 2018-03-27 12:18:18 UTC
On 11.1 amd64,  there seems to be 1 new failure

devel/monotone

Failure log:

http://package18.nyi.freebsd.org/data/111amd64-default-PR220613/2018-03-27_11h57m25s/logs/errors/monotone-1.1_10.log
Comment 12 Adam Weinberger freebsd_committer 2018-05-18 16:05:06 UTC
Over to new maintainer
Comment 13 Kirill Ponomarev freebsd_committer 2018-05-18 18:48:35 UTC
Is devel/monotone the only one which fails with 8.42
Comment 14 Kirill Ponomarev freebsd_committer 2018-05-18 19:44:34 UTC
Asking for exp-run to catch new failures if any after March run.
Comment 15 Adam Weinberger freebsd_committer 2018-05-18 21:17:32 UTC
I can't see as how there'd be any new failures, Kirill. Since the March run, new updates would only *improve* compliance with 8.42.

monotone is the only remaining thing that fails with 8.42. If you feel strongly, we can do another exp-run, but I think it's probably superfluous.
Comment 16 Kirill Ponomarev freebsd_committer 2018-05-18 21:44:04 UTC
Created attachment 193522 [details]
monotone patch

Here is devel/monotone patch to fix build with pcre 8.42
If there's no need for exp-run, I'll commit it
Comment 17 commit-hook freebsd_committer 2018-05-19 06:52:03 UTC
A commit references this bug:

Author: krion
Date: Sat May 19 06:51:06 UTC 2018
New revision: 470355
URL: https://svnweb.freebsd.org/changeset/ports/470355

Log:
  Update to 8.42

  PR:		220613
  Submitted by:	adamw

Changes:
  head/devel/pcre/Makefile
  head/devel/pcre/distinfo
  head/devel/pcre/pkg-plist
Comment 18 commit-hook freebsd_committer 2018-05-19 06:53:06 UTC
A commit references this bug:

Author: krion
Date: Sat May 19 06:52:26 UTC 2018
New revision: 470356
URL: https://svnweb.freebsd.org/changeset/ports/470356

Log:
  Fix build with pcre 8.42

  PR:		220613
  Submitted by:	adamw

Changes:
  head/databases/mongodb32/Makefile
  head/databases/mongodb32/files/patch-pcre
Comment 19 commit-hook freebsd_committer 2018-05-19 06:54:09 UTC
A commit references this bug:

Author: krion
Date: Sat May 19 06:53:20 UTC 2018
New revision: 470357
URL: https://svnweb.freebsd.org/changeset/ports/470357

Log:
  Fix build with pcre 8.42

  PR:		220613
  Submitted by:	adamw

Changes:
  head/databases/mongodb34/Makefile
  head/databases/mongodb34/files/patch-pcre
Comment 20 commit-hook freebsd_committer 2018-05-19 06:55:13 UTC
A commit references this bug:

Author: krion
Date: Sat May 19 06:54:15 UTC 2018
New revision: 470358
URL: https://svnweb.freebsd.org/changeset/ports/470358

Log:
  Fix build with pcre 8.42

  PR:		220613
  Submitted by:	adamw

Changes:
  head/graphics/opencollada/Makefile
  head/graphics/opencollada/files/patch-COLLADABaseUtils_include_COLLADABUPcreCompiledPattern.h
Comment 21 commit-hook freebsd_committer 2018-05-19 06:55:16 UTC
A commit references this bug:

Author: krion
Date: Sat May 19 06:54:55 UTC 2018
New revision: 470359
URL: https://svnweb.freebsd.org/changeset/ports/470359

Log:
  Fix build with pcre 8.42

  PR:		220613
  Submitted by:	maintainer

Changes:
  head/devel/monotone/Makefile
  head/devel/monotone/files/patch-src_pcrewrap.cc
  head/devel/monotone/files/patch-src_pcrewrap.hh