Bug 220620

Summary: devel/libgit2: Update to 0.26.0
Product: Ports & Packages Reporter: Iblis Lin <iblis.dif01>
Component: Individual Port(s)Assignee: William Grzybowski <wg>
Status: Closed FIXED    
Severity: Affects Some People CC: mfechner, w.schwarzenfeld, wg
Priority: --- Keywords: needs-patch, needs-qa
Version: LatestFlags: koobs: maintainer-feedback? (wg)
Hardware: Any   
OS: Any   
Bug Depends on: 223727, 223728    
Bug Blocks:    
Attachments:
Description Flags
libgit2 patch koobs: maintainer-approval-

Description Iblis Lin 2017-07-11 07:07:32 UTC 
Created attachment 184248 [details]
libgit2 patch

changelog is here: https://github.com/libgit2/libgit2/releases

portlint: looks fine.

poudriere testport:
  * pass on 11.0-RELEASE, amd64
  * pass on 11.0-RELEASE, i386
Comment 1 William Grzybowski freebsd_committer freebsd_triage 2017-07-11 11:52:49 UTC 
I cannot commit the patch as is because it will break a few other ports that depend on libgit2 (e.g. py-libgit2, glib libgit2, etc)

I will try to find some time in the next couple weeks to update them.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-11 11:57:17 UTC 
Maintainer will get back to us
Comment 3 Matthias Fechner freebsd_committer freebsd_triage 2017-11-12 07:57:27 UTC 
We have a critical security update for gitlib in the pipe which depends on libgit2 version 0.26.0.
Can I help you to get this update quicker done?
Comment 4 Matthias Fechner freebsd_committer freebsd_triage 2017-11-14 17:16:12 UTC 
I created a review for it:
https://reviews.freebsd.org/D13090
Comment 5 William Grzybowski freebsd_committer freebsd_triage 2017-11-14 17:24:30 UTC 
Sorry, I am completely out of time for this.

Do you want to take maintainership?

Also, as I explained, bumping this lib will break all depending ports, e.g. libgit-glib and py-libgit2
Comment 6 Matthias Fechner freebsd_committer freebsd_triage 2017-11-14 17:39:32 UTC 
Thanks for this information.
Yes I would take over as maintainer.

I will have a look onto devel/libgit2-glib and devel/py-pygit2, but as I do not use it, I cannot test it, but can provide with an updated version that at least builds.

Maybe someone can help then to test it.
Comment 7 Matthias Fechner freebsd_committer freebsd_triage 2017-11-14 18:34:12 UTC 
I have already testbuilds for devel/libgit2-glib and devel/py-pygit2 and running:
https://pkg.fechner.net/build.html?mastername=111amd64-gitlab&build=2017-11-14_18h41m24s

But as llvm is a dependency it will take some time.

Should I create for each update here a bug or should I add several reviews for it (for each update)?

How is a version bump for all ports handled that have a build/run-dependency on libgit2?
Comment 8 William Grzybowski freebsd_committer freebsd_triage 2017-11-14 18:47:06 UTC 
I think adding several reviewers is fine.

In the past all I have done is commit to the main ports affected by it.
Comment 9 Matthias Fechner freebsd_committer freebsd_triage 2017-11-14 21:23:08 UTC 
devel/libgit2-glib:
https://reviews.freebsd.org/D13094

devel/py-pygit2:
https://reviews.freebsd.org/D13095

Both builds were fine.
libgit2 is working as expected but I cannot test the other two ports.
Comment 10 William Grzybowski freebsd_committer freebsd_triage 2017-11-16 17:05:14 UTC 
We need approval from libgit2-glib maintainer
Comment 11 Matthias Fechner freebsd_committer freebsd_triage 2017-11-16 18:34:12 UTC 
I added the maintainer to the review for libgit2-glib.
Comment 12 Matthias Fechner freebsd_committer freebsd_triage 2017-11-29 18:36:17 UTC 
Update was commited, you can closed the ticket, thanks.