Bug 220796
| Summary: | lang/spidermonkey185: Fails to build when devel/readline is built without TERMCAP option | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Miroslav Lachman <000.fbsd> | ||||||
| Component: | Individual Port(s) | Assignee: | Kubilay Kocak <koobs> | ||||||
| Status: | Closed Overcome By Events | ||||||||
| Severity: | Affects Only Me | CC: | rene, w.schwarzenfeld | ||||||
| Priority: | --- | Keywords: | needs-qa | ||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| See Also: |
https://bugzilla.redhat.com/show_bug.cgi?id=499837 https://bugzilla.redhat.com/show_bug.cgi?id=162023 |
||||||||
| Attachments: |
|
||||||||
The official FreeBSD package builders appears successfully build: http://beefy6.nyi.freebsd.org/data/103amd64-default/445629/logs/spidermonkey185-1.8.5_4.log Note the same 33 warnings appear in the log: 33 warnings generated. c++ -o js -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -O2 -pipe -fstack-protector -fno-strict-aliasing -fno-strict-aliasing -pipe -DNDEBUG -DTRIMMED -O js.o -pthread -fstack-protector -Wl,-rpath-link,/bin -Wl,-rpath-link,/usr/local/lib -L../dist/bin -L../dist/lib -L/usr/local/lib -lplds4 -lplc4 -lnspr4 -pthread -lreadline ../libjs_static.a The missing references relate to readline and its need for symbols that come from either ncurses or termcap (depending on how things are built) Can you please confirm for me which OPTIONS are being used for both spidermonkey185 and readline ports, and if any OPTIONS are modified from their default values, revert those and confirm whether or not symptoms are still reproducible (In reply to Kubilay Kocak from comment #1) Thank you for the pointer! I had this options for readline # This file is auto-generated by 'make config'. # Options for readline-6.3.8 _OPTIONS_READ=readline-6.3.8 _FILE_COMPLETE_OPTIONS_LIST=DOCS TERMCAP OPTIONS_FILE_UNSET+=DOCS OPTIONS_FILE_UNSET+=TERMCAP I changed it to OPTIONS_FILE_SET+=TERMCAP and bulk build works again. The question is - why it is failing now if it was OK for a long time before with unset TERMCAP? Is there some way to check and warn users of spidermonkey185 that it needs readline with TERMCAP on? As my problem is solved, you can close this PR if you want. TERMCAP is per default ON. Could we close here? (In reply to w.schwarzenfeld from comment #3) What? If there is an option and it does not work, then it is a bug and should be fixed or option removed. Regardless of default settings. Defaults are just ... defaults for pkg build cluster. Something other
The Makefile has a typo
DEBUG_CONFIGURE_ON= --enable-debug-sumbols
^
I had another problem: It does not configure if readline is build without TERMCAP. But I got it to build, if I add to the Makefile: LDFLAGS+=-L/usr/local/lib LIBS+= -lreadline -ltinfo Created attachment 207394 [details]
svn-diff-spidermonkey185
I hope this is right.
This is an old version of spidermonkey which is python27-only, please use a recent version. |
Created attachment 184428 [details] Poudriere bulk build log failure Cannot upgrade / build Spidermonkey185 in our Poudriere. It throws 33 warnings and then end up with error: 33 warnings generated. c++ -o js -fno-rtti -fno-exceptions -Wall -Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wcast-align -Wno-invalid-offsetof -Wno-variadic-macros -Werror=return-type -pedantic -Wno-long-long -O2 -pipe -DJS_C_STRINGS_ARE_UTF8 -fstack-protector -fno-strict-aliasing -fno-strict-aliasing -pipe -DNDEBUG -DTRIMMED -O js.o -pthread -fstack-protector -Wl,-rpath-link,/bin -Wl,-rpath-link,/usr/local/lib -L../dist/bin -L../dist/lib -L/usr/local/lib -lplds4 -lplc4 -lnspr4 -pthread -lreadline ../libjs_static.a /usr/local/lib/libreadline.so: undefined reference to `PC' /usr/local/lib/libreadline.so: undefined reference to `tgetflag' /usr/local/lib/libreadline.so: undefined reference to `tgetent' /usr/local/lib/libreadline.so: undefined reference to `UP' /usr/local/lib/libreadline.so: undefined reference to `tputs' /usr/local/lib/libreadline.so: undefined reference to `tgoto' /usr/local/lib/libreadline.so: undefined reference to `tgetnum' /usr/local/lib/libreadline.so: undefined reference to `BC' /usr/local/lib/libreadline.so: undefined reference to `tgetstr' c++: error: linker command failed with exit code 1 (use -v to see invocation) gmake[3]: *** [../config/rules.mk:1024: js] Error 1 gmake[3]: Leaving directory '/wrkdirs/usr/ports/lang/spidermonkey185/work/js-1.8.5/js/src/shell' gmake[2]: *** [config/rules.mk:909: libs] Error 2 gmake[2]: Leaving directory '/wrkdirs/usr/ports/lang/spidermonkey185/work/js-1.8.5/js/src' gmake[1]: *** [config/rules.mk:754: all] Error 2 gmake[1]: Leaving directory '/wrkdirs/usr/ports/lang/spidermonkey185/work/js-1.8.5/js/src' *** Error code 1 Stop. make: stopped in /usr/ports/lang/spidermonkey185 ====>> Cleaning up wrkdir ===> Cleaning for spidermonkey185-1.8.5_4 build of lang/spidermonkey185 ended at Fri Jul 14 17:51:07 CEST 2017 build time: 00:04:33 !!! build failure encountered !!! Full log attached The make.conf contains OPTIONS_UNSET= X11 GUI CUPS DOCS EXAMPLES NLS HAL WITH_BDB_VER=5 WITH_GHOSTSCRIPT_VER=9 DEFAULT_VERSIONS=apache=2.4 perl5=5.24 mysql=10.1m php=5.6 python=2.7 python3=3.5 pgsql=9.4 ssl=openssl DISABLE_LICENSES=yes