Bug 220843
| Summary: | audio/wildmidi: Update to 0.4.1 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | SimaMoto,RyōTa <liangtai.s16> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Richard Gallamore <ultima> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | CC: | admin, liangtai.s16, ultima | ||||||||||
| Priority: | --- | Flags: | koobs:
maintainer-feedback+
koobs: merge-quarterly? |
||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
SimaMoto,RyōTa
2017-07-19 04:14:36 UTC
Thank you for your report and patch. If you could separate the version update from the other changes (non feature improvements / bugfixes), it will ensure those can be merged to quarterly branch users Please also confirm that these changes pass QA (portlint and poudriere in particular). For more testing information and instructions, see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html Created attachment 184529 [details] Fix undeclared error of ONLCR Separated patch 1/2: Fix build error of audio/wildmidi for upcoming releases and the current branch after mfc r318780. http://beefy11.nyi.freebsd.org/data/head-i386-default/p446242_s321261/logs/wildmidi-0.4.0.log http://beefy12.nyi.freebsd.org/data/head-amd64-default/p446242_s321261/logs/wildmidi-0.4.0.log Created attachment 184531 [details]
Upgrade from ver. 0.4.0 to ver. 0.4.1
Update audio/wildmidi to the version 0.4.1 and convert to the latest
options framework.
Created attachment 184532 [details]
testcase of i386/11.0R for ver 0.4.1
poudriere test in FreeBSD 11.0-RELEASE i386 succeeds. (the extra patch is not used.)
If the two patch files should be added, please combined them into one patch file. Thanks. @Richard Fixes separated from version updates (as attachments in the issue tracker) are OK and preferred so that its clear/obvious to committers and so fixes can be merged (MFH) independently from version updates. Having said that, its not clear or made explicit whether the fix is independent or relies on the update being made first Comment on attachment 184532 [details]
testcase of i386/11.0R for ver 0.4.1
Logs don't need approval
(In reply to Kubilay Kocak from comment #6) These separated patches does not depend on each other, and any of both can be applied earlier than the other. The bugfix patch is much important than the upgrading patch, therefore the bug results in BROKEN status of this port for the system on several latest FreeBSD branches that will be upcoming releases. (In reply to Kubilay Kocak from comment #6) Ah, I understand now, the other one was separated for MFC. I'll start qa. I'm not really sure why grep is piped into xargs with reinplace_cmd in the post-patch target. Is this really required? Dropping the grep and xargs and only using reinplace_cmd should work just fine or am I missing something? A commit references this bug: Author: ultima Date: Thu Aug 3 18:36:52 UTC 2017 New revision: 447274 URL: https://svnweb.freebsd.org/changeset/ports/447274 Log: This change will fix BROKEN status on several latest FreeBSD branches that will be upcoming releases. PR: 220843 Submitted by: SimaMoto,Ry?Ta <liangtai.s16@gmail.com> (maintainer) Reviewed by: matthew (mentor) Approved by: matthew (mentor) MFH: 2017Q3 Differential Revision: https://reviews.freebsd.org/D11829 Changes: head/audio/wildmidi/Makefile head/audio/wildmidi/files/ head/audio/wildmidi/files/extra-patch-src_wm__tty.c The first patch committed, waiting for MFC approval. A commit references this bug: Author: ultima Date: Thu Aug 3 19:24:45 UTC 2017 New revision: 447276 URL: https://svnweb.freebsd.org/changeset/ports/447276 Log: MFH: r447274 This change will fix BROKEN status on several latest FreeBSD branches that will be upcoming releases. PR: 220843 Submitted by: SimaMoto,Ry?Ta <liangtai.s16@gmail.com> (maintainer) Reviewed by: matthew (mentor) Approved by: matthew (mentor) Differential Revision: https://reviews.freebsd.org/D11829 Approved by: ports-secteam Changes: _U branches/2017Q3/ branches/2017Q3/audio/wildmidi/Makefile branches/2017Q3/audio/wildmidi/files/ A commit references this bug: Author: ultima Date: Tue Aug 8 17:53:36 UTC 2017 New revision: 447551 URL: https://svnweb.freebsd.org/changeset/ports/447551 Log: * Updated to 0.4.1 * Cleanup Makefile PR: 220843 Submitted by: SimaMoto,Ry?Ta (maintainer) Reviewed by: matthew (mentor), mat Approved by: matthew (mentor) Differential Revision: https://reviews.freebsd.org/D11831 Changes: head/audio/wildmidi/Makefile head/audio/wildmidi/distinfo head/audio/wildmidi/pkg-plist Committed, thanks! |
