Bug 220857

Description Peter Wemm 2017-07-19 16:36:30 UTC

This happens on 11.x and 12.x:


In file included from src/mongo/db/db.cpp:47:
src/mongo/db/client.h:263:59: error: ordered comparison between pointer and zero ('mongo::Client *' and 'int')
    inline bool haveClient() { return currentClient.get() > 0; }
                                      ~~~~~~~~~~~~~~~~~~~ ^ ~
In file included from src/mongo/db/db.cpp:49:
In file included from src/mongo/db/commands/server_status.h:36:
In file included from src/mongo/db/stats/counters.h:37:
In file included from src/mongo/db/pdfile.h:41:
In file included from src/mongo/db/catalog/database.h:33:
In file included from src/mongo/db/structure/catalog/namespace_details.h:34:
In file included from src/mongo/db/structure/catalog/index_details.h:40:
src/mongo/db/structure/catalog/namespace.h:58:65: error: ordered comparison between pointer and zero ('const char *' and 'int')
        bool hasDollarSign() const { return strchr( buf , '$' ) > 0;  }
                                            ~~~~~~~~~~~~~~~~~~~ ^ ~
In file included from src/mongo/db/db.cpp:60:
In file included from src/mongo/db/instance.h:34:
In file included from src/mongo/client/dbclientinterface.h:1401:
src/mongo/client/dbclientcursor.h:120:40: warning: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion]
        bool isDead() const { return  !this || cursorId == 0; }
                                      ~^~~~
In file included from src/mongo/db/db.cpp:71:
In file included from src/mongo/db/repl/rs.h:39:
In file included from src/mongo/db/repl/rs_config.h:37:
In file included from src/mongo/util/concurrency/race.h:31:
src/mongo/util/concurrency/mutexdebugger.h:90:17: warning: 'this' pointer cannot be null in well-defined C++ code; comparison may be assumed to always evaluate to false [-Wtautological-undefined-compare]
            if( this == 0 || m == 0 ) return;
                ^~~~    ~
src/mongo/util/concurrency/mutexdebugger.h:150:17: warning: 'this' pointer cannot be null in well-defined C++ code; comparison may be assumed to always evaluate to false [-Wtautological-undefined-compare]
            if( this == 0 || m == 0 ) return; // still in startup pre-main()
                ^~~~    ~
3 warnings and 2 errors generated.
scons: *** [build/freebsd/cc_cc/cxx_c++/ssl/use-system-pcre/use-system-snappy/use-system-v8/mongo/db/db.o] Error 1
scons: building terminated because of errors.
*** Error code 1

Stop.
make: stopped in /usr/ports/databases/mongodb

Note: the regular package builders are using old 11.x and 12.x build jails.  For the cluster we use relatively recent build jails.  In this case, both are from June 2017.