Bug 220861
| Summary: | textproc/py-pytidylib: Update to 0.3.2, Add tidy-html5 support, Add py3 counterpart | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Marakasov <amdmi3> | ||||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | Keywords: | needs-patch, needs-qa | ||||||
| Priority: | --- | Flags: | amdmi3:
maintainer-feedback-
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Thank you Dmitry - Are the two libraries drop-in replacements for each other? - What considerations (if any) might there be for users when switching from the current default to the other? - Does the test target still work after removing the setup.py patch? I don't believe it will (test_suite is one way of enabling the test command) - Is the py3- port for a particular dependent port? - USES=python:<version-spec> should be X.Y+ (matching upstream support declarations) rather than pointing to the metaport (:3) - I like 'BACKEND' as the option (group) name, and 'library' is still retained in the group description. Thoughts? (In reply to Kubilay Kocak from comment #1) > - Are the two libraries drop-in replacements for each other? This is the same project, tidy-html5 is just the newer version. > - What considerations (if any) might there be for users when switching from > the current default to the other? None that I know of. In fact, the older library is just useless since it fails on any modern HTML construct. > - Does the test target still work after removing the setup.py patch? I don't > believe it will (test_suite is one way of enabling the test command) You're right, this is still needed. > - Is the py3- port for a particular dependent port? > > - USES=python:<version-spec> should be X.Y+ (matching upstream support > declarations) rather than pointing to the metaport (:3) No longer applicable. > - I like 'BACKEND' as the option (group) name, and 'library' is still > retained in the group description. Thoughts? Fixed. The original submission was also lacking a required patch. Created attachment 188956 [details]
Patch
Maintainer timeout A commit references this bug: Author: amdmi3 Date: Wed Jan 10 17:29:23 UTC 2018 New revision: 458663 URL: https://svnweb.freebsd.org/changeset/ports/458663 Log: - Update to 0.3.2 - Support both tidy and tidy-html5 libraries as a backend. The former is practically useless nowadays as it doesn't handle any HTML5 tags, so the latter is the default. PR: 220861 Approved by: matainainer timeout (koobs, 3 weeks) Changes: head/textproc/py-pytidylib/Makefile head/textproc/py-pytidylib/distinfo head/textproc/py-pytidylib/files/patch-setup.py head/textproc/py-pytidylib/files/patch-tidylib_tidy.py |
Created attachment 184511 [details] Patch - Update to 0.3.2 - Add an option to choose a backend between tidy-lib and tidy-html5. Use the latter by default as the former is gravely outdated and does not support HTML5 - Fix hidden dependencies: the module will only use tidy-lib it was build with - Add py3- counterpart