Bug 22088

Summary: ppp filter documentation errors
Product: Documentation Reporter: bigotfo <bigotfo>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description bigotfo 2000-10-18 16:30:01 UTC 
Section 6.2 'Playing with PPP filters' of the pedantic ppp primer at:

http://www.freebsd.org/tutorials/ppp/x879.html

refers to filter syntax as afilter, dfilter, ifilter etc.
whereas they actually need to be filter alive, filter dial etc.

----------------------Also---------------------------------------------

/usr/share/examples/ppp/ppp.conf.sample

Shows example filter lines of the form:

    set filter alive 0 deny udp src eq 520         # routed
    set filter alive 1 deny udp dst eq 520         # routed
    set filter alive 2 deny udp src eq 513         # rwhod
    set filter alive 3 deny udp src eq 525         # timed

All of these lines fail with syntax errors like:

Warning: ParseUdpOrTcp: bad src/dst port syntax:

Apparently because of the remarks!

Fix: 

Remove the remarks, or suggest in
/usr/share/examples/ppp/ppp.conf.sample that trailing remarks
should not be left on filter lines in a working ppp.conf.
How-To-Repeat: Use 'set filter' lines in ppp.conf with trailing remarks.
Comment 1 john253 2000-11-21 01:23:03 UTC 
On further investigation I found that the trailing
remark problem applies to any line in ppp.conf but
only if there are two or more spaces or tabs before
the '#' eg:

 set speed 115200 # works
 set speed 115200  # fails

Should I submit this as a problem with ppp
rather than a documentation problem?

John.
Comment 2 ben freebsd_committer freebsd_triage 2000-11-23 10:08:25 UTC 
State Changed
From-To: open->closed

Committed, thanks! 

The PPP Primer was updated, and PPP has already been fixed to cope with 
remarks correctly, so that is no longer an issue.