Bug 220920

Summary: multimedia/mpv: Fix 0.26.0 regression with oss output
Product: Ports & Packages Reporter: Oleh Hushchenkov <o.hushchenkov>
Component: Individual Port(s)Assignee: Carlos J. Puga Medina <cpm>
Status: Closed FIXED    
Severity: Affects Some People CC: o.hushchenkov
Priority: --- Keywords: patch
Version: LatestFlags: cpm: maintainer-feedback+
Hardware: Any   
OS: Any   
URL: https://github.com/mpv-player/mpv/issues/4642
Attachments:
Description Flags
Fix from upstream
none
Fix from upstream cpm: maintainer-approval+

Description Oleh Hushchenkov 2017-07-22 07:13:54 UTC
Created attachment 184587 [details]
Fix from upstream

After update to 0.26.0 I see this errors in terminal when mpv play audio track:
[ao/oss] Audio device returned broken buffer state (sent 64 samples, got 0 samples, 8 period)!
[ao/oss] Audio device returned broken buffer state (sent 64 samples, got 0 samples, 8 period)!
[ao/oss] Audio device returned broken buffer state (sent 64 samples, got 0 samples, 8 period)!

Upstream issue: https://github.com/mpv-player/mpv/issues/4642
Fixesd in upstream commit: https://github.com/mpv-player/mpv/commit/8c82555e41a6a9edb677756cfe89f28a2918be2a
Comment 1 Oleh Hushchenkov 2017-07-22 10:53:47 UTC
Created attachment 184594 [details]
Fix from upstream

Upload correct patch
Comment 2 commit-hook freebsd_committer 2017-07-22 12:48:17 UTC
A commit references this bug:

Author: cpm
Date: Sat Jul 22 12:48:07 UTC 2017
New revision: 446396
URL: https://svnweb.freebsd.org/changeset/ports/446396

Log:
  - Add a patch from upstream to fix a dumb calculation in ao_oss.c
  - Bump PORTREVISION

  While I'm here pet portlint, USE_* comes before USES

  PR:		220920
  Submitted by:	Oleh Hushchenkov <gor@clogic.com.ua>
  Obtained from:	https://github.com/mpv-player/mpv/commit/8c82555e41a6a9edb677756cfe89f28a2918be2a

Changes:
  head/multimedia/mpv/Makefile
  head/multimedia/mpv/distinfo
Comment 3 Carlos J. Puga Medina freebsd_committer 2017-07-22 12:50:13 UTC
Committed with minor changes, thanks!