Bug 220953
| Summary: | rwho/ruptime incorrectly included in rcmds package set | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Peter Wemm <peter> |
| Component: | bin | Assignee: | Jeremie Le Hen <jlh> |
| Status: | Closed FIXED | ||
| Severity: | Affects Many People | CC: | allanjude, emaste, fullermd |
| Priority: | --- | ||
| Version: | CURRENT | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
Peter Wemm
2017-07-23 22:12:16 UTC
I'm fine changing that, but then there was a mistake in the usage of WITH(OUT)_RCMDS:
$ grep RCMDS usr.bin/Makefile usr.sbin/Makefile bin/Makefile sbin/Makefile
usr.bin/Makefile:SUBDIR.${MK_RCMDS}+= rlogin
usr.bin/Makefile:SUBDIR.${MK_RCMDS}+= rsh
usr.bin/Makefile:SUBDIR.${MK_RCMDS}+= ruptime
usr.bin/Makefile:SUBDIR.${MK_RCMDS}+= rwho
usr.sbin/Makefile:SUBDIR.${MK_RCMDS}+= rwhod
bin/Makefile:SUBDIR.${MK_RCMDS}+= rcp
Sent https://reviews.freebsd.org/D11743 for review.
The port also doesn't include the rc.d script for rwhod, so there's no current way other than manually to get it running. A commit references this bug: Author: jlh Date: Thu Aug 3 21:30:12 UTC 2017 New revision: 322029 URL: https://svnweb.freebsd.org/changeset/base/322029 Log: rwho/ruptime/rwhod shouldn't be gated by RCMDS. PR: 220953 Reported by: peter@ Differential Revision: https://reviews.freebsd.org/D11743 Changes: head/usr.bin/Makefile head/usr.sbin/Makefile A commit references this bug: Author: jlh Date: Thu Aug 3 21:37:57 UTC 2017 New revision: 322031 URL: https://svnweb.freebsd.org/changeset/base/322031 Log: Remove deprecation notice for ruptime/rwho/rwhod. PR: 220953 Reported by: peter Changes: head/usr.bin/ruptime/ruptime.1 head/usr.bin/rwho/rwho.1 head/usr.sbin/rwhod/rwhod.8 A commit references this bug: Author: jlh Date: Tue Aug 8 20:07:09 UTC 2017 New revision: 322276 URL: https://svnweb.freebsd.org/changeset/base/322276 Log: Revert r322029 and r322031 so as to recommit them with a better commit log. PR: 220953 Reported by: ngie@ Changes: head/usr.bin/Makefile head/usr.bin/ruptime/ruptime.1 head/usr.bin/rwho/rwho.1 head/usr.sbin/Makefile head/usr.sbin/rwhod/rwhod.8 A commit references this bug: Author: jlh Date: Tue Aug 8 20:17:08 UTC 2017 New revision: 322277 URL: https://svnweb.freebsd.org/changeset/base/322277 Log: rwho/ruptime/rwhod shouldn't be gated by RCMDS. As peter@ points out in pr/220953: "rwho, rwhod and ruptime are not part of the remote login suite (rsh, rlogin etc). They should *not* be in the rcmds package which is disabled by default. We rely on rwho/rwhod/ruptime in the freebsd.org cluster." This commit is a re-commit of r322029 and r322031 with a better commit log, as pointed out by ngie@. This also includes the necesary changes to OptionalObsoleteFiles.inc, as requested by jhb@. PR: 220953 Reported by: peter@, jhb@ Differential Revision: https://reviews.freebsd.org/D11743 Changes: head/tools/build/mk/OptionalObsoleteFiles.inc head/usr.bin/Makefile head/usr.bin/ruptime/ruptime.1 head/usr.bin/rwho/rwho.1 head/usr.sbin/Makefile head/usr.sbin/rwhod/rwhod.8 A commit references this bug: Author: jhb Date: Tue Aug 15 22:16:16 UTC 2017 New revision: 322552 URL: https://svnweb.freebsd.org/changeset/base/322552 Log: Unconditionally install rwhod support scripts. r322277 moved rwho* and ruptime out of the MK_RCMDS conditional including updating the obsolete files entries to not remove these scripts due to WITHOUT_RCMDS=yes. However, the initial installation was still conditional on MK_RCMDS, so new installs did not include these scripts and upgrades via mergemaster or etcupdate removed them. PR: 220953 MFC after: 1 month Changes: head/etc/periodic/daily/Makefile head/etc/rc.d/Makefile This seems fixed. Can this be closed? I think we also need to update the deprecation notice in the man pages. A commit references this bug: Author: emaste Date: Sun Mar 11 17:40:03 UTC 2018 New revision: 330769 URL: https://svnweb.freebsd.org/changeset/base/330769 Log: MFC r322277 by jlh: rwho/ruptime/rwhod shouldn't be gated by RCMDS. As peter@ points out in pr/220953: "rwho, rwhod and ruptime are not part of the remote login suite (rsh, rlogin etc). They should *not* be in the rcmds package which is disabled by default. We rely on rwho/rwhod/ruptime in the freebsd.org cluster." This commit is a re-commit of r322029 and r322031 with a better commit log, as pointed out by ngie@. This also includes the necesary changes to OptionalObsoleteFiles.inc, as requested by jhb@. PR: 220953 Changes: _U stable/11/ stable/11/tools/build/mk/OptionalObsoleteFiles.inc stable/11/usr.bin/Makefile stable/11/usr.bin/ruptime/ruptime.1 stable/11/usr.bin/rwho/rwho.1 stable/11/usr.sbin/Makefile stable/11/usr.sbin/rwhod/rwhod.8 A commit references this bug: Author: emaste Date: Sun Mar 11 17:43:05 UTC 2018 New revision: 330770 URL: https://svnweb.freebsd.org/changeset/base/330770 Log: MFC r322552 by jhb: Unconditionally install rwhod support scripts. r322277 moved rwho* and ruptime out of the MK_RCMDS conditional including updating the obsolete files entries to not remove these scripts due to WITHOUT_RCMDS=yes. However, the initial installation was still conditional on MK_RCMDS, so new installs did not include these scripts and upgrades via mergemaster or etcupdate removed them. PR: 220953 Changes: _U stable/11/ stable/11/etc/periodic/daily/Makefile stable/11/etc/rc.d/Makefile |