Bug 220973
| Summary: | net/gopher: Update to 3.0.6, Take MAINTAINER'ship, portlint cleanup | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Aaron Baugher <aaron> | ||||||||
| Component: | Individual Port(s) | Assignee: | Richard Gallamore <ultima> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Only Me | CC: | ultima | ||||||||
| Priority: | --- | Keywords: | needs-patch | ||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 184669 [details]
Poudriere testport log for net/gopher on 11.0 amd64
Created attachment 184670 [details]
Poudriere testport log for net/gopher on 11.0 i386
Thank you for offering to take maintainership of a port Aaron Note for future issues that attaching QA logs is not necessary unless requested, but please continue to confirm what QA has been run and their results, something like: portlint: OK (looks fine.) testport: OK (poudriere: <versions>, <archs>, <options> tested) maketest: OK (XXX passed, 0 failed) (In reply to Kubilay Kocak from comment #3) Thanks, I'll do that. (In reply to Aaron Baugher from comment #4) Does the source come with a license file? Is adding LICENSE_FILE possible? (In reply to Richard Gallamore from comment #5) Yes, it has one in ${WRKSRC}/COPYING. Should I add that and attach a revised diff here? Thank you. Yes please Aaron :) A commit references this bug: Author: ultima Date: Tue Aug 8 22:15:25 UTC 2017 New revision: 447579 URL: https://svnweb.freebsd.org/changeset/ports/447579 Log: * Give maintainer to submitter, Aaron Baugher * Added license information * Cleaned up Makefile PR: 220973 Submitted by: Aaron Baugher (maintainer) Reviewed by: matthew (mentor), mat Approved by: matthew (mentor) Differential Revision: https://reviews.freebsd.org/D11897 Changes: head/net/gopher/Makefile head/net/gopher/files/patch-gopher_form.c head/net/gopher/files/patch-object_BLblock.c head/net/gopher/files/patch-object_GSgopherobj.c head/net/gopher/files/patch-object_Regex.c head/net/gopher/files/patch-object_url.c Added the license file and committed, thanks. Thank you. I was trying to create a new diff with the LICENSE_FILE added, and couldn't figure out why the diff was empty, and it was because you had already made the change! Thanks again. |
Created attachment 184668 [details] 'svn diff' of net/gopher changes. I'd like to be the maintainer for this port, because I miss gopher from the old days and I'm working on a gopher server, so I use this client sometimes. I bumped PORTREVISION because adding the LICENSE to the Makefile added files to the resulting package. I also cleaned up several portlint errors and warnings, including turning the ports into 'make makepatch' ports, reordering the lines in the Makefile, and adding the license. Tested in poudriere, will attach logs.