Summary: | editors/abiword: Fails to build with GRAMMAR option enabled (update to 3.0.2 ) | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Grzegorz Junka <list1> | ||||||||||||||
Component: | Individual Port(s) | Assignee: | Walter Schwarzenfeld <w.schwarzenfeld> | ||||||||||||||
Status: | Closed Overcome By Events | ||||||||||||||||
Severity: | Affects Only Me | CC: | lantw44, ralph, val, vishwin, w.schwarzenfeld | ||||||||||||||
Priority: | --- | Keywords: | needs-qa | ||||||||||||||
Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(gnome) koobs: merge-quarterly? |
||||||||||||||
Hardware: | Any | ||||||||||||||||
OS: | Any | ||||||||||||||||
Attachments: |
|
Description
Grzegorz Junka
2017-07-24 18:57:21 UTC
Make Summary more verbose. Do you mean I should put a more verbose option to the compilation or explain more clearly that the build fails when this particular option is enabled? Ah, ok, sorry, didn't see your next comment as I was logged out. Created attachment 190587 [details] test-svn-diff-update-abiword-3.0.2 This is a try to update abiword to 3.0.2. Builds on 10.4 und 11.1 fine. Starts normal (except the standard zoom is to big at first start - needs changed to 100%9). Needs runtest. ChangeLog: https://www.abisource.com/release-notes/3.0.2.phtml This also compiles with GRAMMAR=on. (In reply to w.schwarzenfeld from comment #5) Thanks for the patch. In addition to it, I had to - delete the *DocumentRDF patches that didn't apply - add CXXFLAGS+=-std=c++98 (since you deleted the C++11 patch) and now it works fine on 12-CURRENT. I have no 12.0, so I overlooked the c++11 patch. Can you try to add a patch to mine? Next days I don't really I have time to look in it. (In reply to w.schwarzenfeld from comment #7) I think adding CXXFLAGS+=-std=c++98 is actually better than recreating that patch. We don't gain anything from compiling in C++11/17 mode, the code is valid C++98, let's just tell the compiler that it's C++98. I've rolled up both the initial patch and subsequent comments into a pull request on gnome@'s devel git repository. I've also removed the NLS option as not only is the configure option deprecated (manifested as unknown option warning) but gettext is not needed. Passes testport. https://github.com/freebsd/freebsd-ports-gnome/pull/11 (In reply to Charlie Li from comment #9) Now at https://github.com/freebsd/freebsd-ports-gnome/pull/13 . No changes to the patch. New error: use of undeclared identifier 'icaltime_from_timet' (pd_DocumentRDF.cpp) There is a patch: https://www.mail-archive.com/arch-commits@archlinux.org/msg381957.html libical-deprecated.patch Created attachment 197643 [details]
svn-diff-abiword_v2
Updated patch including ical-patch.
Created attachment 200348 [details] svn-diff-abiword_v3 Update patch after ports r488056. Created attachment 200349 [details]
svn-diff-abiword_v4
Attached a wrong svn-diff.
Created attachment 203361 [details]
Patches updated to build on current ports tree in 12-RELEASE.
Created attachment 203363 [details]
svn-diff-abiword-3.0.2
Cleaned up patch-configure
One and a half year and no reaction from gnome! Reset Maintainer. See update to 3.0.4 bug #243652. |