Bug 220992
| Summary: | audio/xmms2-scrobbler broken | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | emz | ||||
| Component: | Individual Port(s) | Assignee: | Eugene Grosbein <eugen> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | eugen | ||||
| Priority: | --- | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: eugen Date: Tue Jul 25 09:08:31 UTC 2017 New revision: 446563 URL: https://svnweb.freebsd.org/changeset/ports/446563 Log: Fix Lasf.fm API 1.x compatibility. User may disable new option APIFIX in case it breaks compatibility with alternative services. PR: 220992 Submitted by: Eugene Zheganin Approved by: az (mentor) Changes: head/audio/xmms2-scrobbler/Makefile head/audio/xmms2-scrobbler/files/extra-patch-xmms2-scrobbler.c Committed, thanks! A commit references this bug: Author: tobik Date: Sat May 25 15:12:08 UTC 2019 New revision: 502578 URL: https://svnweb.freebsd.org/changeset/ports/502578 Log: audio/xmms2-scrobbler: Revert r446562 and remove nop APIFIX option The APIFIX option never did anything. There is no APIFIX_EXTRA_PATCHES_ON options helper. PR: 220992 Changes: head/audio/xmms2-scrobbler/Makefile head/audio/xmms2-scrobbler/files/extra-patch-xmms2-scrobbler.c The patch was never applied correctly. Reopen in case this is still relevant. A commit references this bug: Author: eugen Date: Sat May 25 15:31:20 UTC 2019 New revision: 502579 URL: https://svnweb.freebsd.org/changeset/ports/502579 Log: audio/xmms2-scrobbler: re-apply fix correctly Wrong APIFIX_EXTRA_PATCHES_ON changed to right APIFIX_EXTRA_PATCHES Thanks to tobik for reporting this. Bump PORTREVISION. PR: 220992 Submitted by: Eugene Zheganin Reported by: tobik Changes: head/audio/xmms2-scrobbler/Makefile head/audio/xmms2-scrobbler/files/extra-patch-xmms2-scrobbler.c |
Created attachment 184688 [details] a patch fixing the 1.x Last.fm API support. After Lasf.fm 1.x API bump during autumn 2015 xmms2-scrobbler stopped working. Now it complains like ===Cut=== registering lastfm starting thread for lastfm no newline (1) handshake failed handshake failed ===Cut=== The attached patch resolves this problem, it was tested on 11.0-RELEASE-p5 and last.fm. Various old bug reports (not FreeBSD PRs) state that xmms2-scrobbler was working with Libre.fm _without_ this patch (at least in 2015), so it's probably still working with Libre.fm and if it's so, it's very likely that this patch will break this _if_ Last.fm 1.x API differs from Libre API now. In this case the port can be adjusted in a way when the user is prompted to chose which API to assemble this port with (Last.fm - with this patch, others lLast.fm derivatives - without). Since this PR is the only PR at this time mentioning this port, and since the primary use of this port is the audioscrobbling to Last.fm, as the pkg-descr states, I propose to just commit this patch in, until some complaints about libre.fm will be received, if any. Then the dialog will be added. I cannot prove whether Libre.fm is working or not, since I don't have the account there.