Bug 221009
| Summary: | net-mgmt/smokeping: rc script does not wait for smokeping to finish | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Kajetan Staszkiewicz <vegeta> | ||||
| Component: | Individual Port(s) | Assignee: | Rodrigo Osorio <rodrigo> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | sascha.folie | ||||
| Priority: | --- | Keywords: | easy, needs-qa | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(rodrigo) koobs: merge-quarterly? |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: rodrigo Date: Mon Jul 31 22:15:04 UTC 2017 New revision: 447003 URL: https://svnweb.freebsd.org/changeset/ports/447003 Log: Add a wait_for_pids at the end of the rc script stop function, waiting for the daemon to stops. With smokeping busy pinging a few hundred hosts it often occurs that the daemon stops after the rc call completion failing a restart. Bump PORTREVISION. PR: 221009 Submitted by: vegeta@tuxpowered.net Changes: head/net-mgmt/smokeping/Makefile head/net-mgmt/smokeping/files/smokeping.in Committed, thanks |
Created attachment 184708 [details] Wait for smokeping to terminate With smokeping busy pinging a few hundred hosts it will often not terminate immediately when asked to do so. Therefore restarting is often impossible because the old smokeping still runs when a new one tries to start. I think a simple `wait_for_pids` should do the trick. Please see the attached diff.