Bug 221049
| Summary: | struct ata_params word 49 has bits for IORDY and IORDYDIS swapped | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | aaron.styx | ||||
| Component: | kern | Assignee: | Alexander Motin <mav> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | emaste, mav | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | CURRENT | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: mav Date: Sat Jul 29 13:54:28 UTC 2017 New revision: 321685 URL: https://svnweb.freebsd.org/changeset/base/321685 Log: Fix IORDY bits definition. According to the ATA specs, IORDYDIS should be bit 10, IORDY -- bit 11. PR: 221049 Submitted by: aaron.styx@baesystems.com MFC after: 1 week Changes: head/sys/sys/ata.h Fixed. Thank you! A commit references this bug: Author: mav Date: Sat Aug 5 08:37:09 UTC 2017 New revision: 322080 URL: https://svnweb.freebsd.org/changeset/base/322080 Log: MFC r321685: Fix IORDY bits definition. According to the ATA specs, IORDYDIS should be bit 10, IORDY -- bit 11. PR: 221049 Submitted by: aaron.styx@baesystems.com Changes: _U stable/11/ stable/11/sys/sys/ata.h A commit references this bug: Author: mav Date: Sat Aug 5 08:37:38 UTC 2017 New revision: 322081 URL: https://svnweb.freebsd.org/changeset/base/322081 Log: MFC r321685: Fix IORDY bits definition. According to the ATA specs, IORDYDIS should be bit 10, IORDY -- bit 11. PR: 221049 Submitted by: aaron.styx@baesystems.com Changes: _U stable/10/ stable/10/sys/sys/ata.h |
Created attachment 184771 [details] Fix IORDY bits In sys/sys/ata.h, word 49 of the struct ata_params defines ATA_SUPPORT_IORDYDIS and ATA_SUPPORT_IORDY. According to the ATA spec, IORDYDIS should be bit 10, IORDY should be bit 11. Attached a fix.