Bug 221059
| Summary: | release: scripts/mk-vmimage.sh does not fail on error | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Johannes Jost Meixner <xmj> |
| Component: | misc | Assignee: | freebsd-bugs (Nobody) <bugs> |
| Status: | New --- | ||
| Severity: | Affects Only Me | CC: | emaste |
| Priority: | --- | ||
| Version: | 10.3-STABLE | ||
| Hardware: | Any | ||
| OS: | Any | ||
I think the solution is: "don't do that." The script really ought to be checking for errors. We shouldn't have silent failure / broken output from a misconfigured parameter. The parameter is not misconfigured in this case. The value is too small, and the error case (filesystem full) won't be known until it is triggered. (In reply to Glen Barber from comment #3) I agree in that it's a user error (in this case, things worked with 2016Q2 packages but not 2017Q2 packages due to growing size). However, even then, issues could occur (filesystem full, something else in the script breaks, ...) and mk-vmimage.sh would *still* continue trying to upload the broken VM image to EC2. And it really shouldn't do that. (In reply to Johannes Jost Meixner from comment #4) (To clarify, by "filesystem" I mean in this case the physical disk $OBJDIR is on.) |
I'm currently trying to build AMI images, and I've noticed that one of the components of release behaves interestingly: During `make ec2ami` (more specifically, the cw-ec2 target) Makefile calls out to scripts/mk-vmimage.sh. This script in turn sources its functions from tools/vmimage.subr. However, if for instance an error is obtained during the `vm_copy_base` phase, the script will continue as if nothing happens, and even end with a return value of 0. In my case, while trying to copy the "old" image's contents to the "new" image, the file-backed memorydisk was set to 5000M (too small for the packages I added in). No step in mk-vmimage.sh will actually fail -- especially not the `vm_copy_base` step -- and the new system will end up missing arbitrary files. Steps to reproduce: 1. in ${EC2CONF}, Set a VMSIZE that is too small to host the base system and all extra packages. 2. make WITH_CLOUDWARE=yes [...] ec2ami