Bug 221073
| Summary: | net-im/gloox: Update to 1.0.20 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Demetris Procopiou <dem.procopiou> | ||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Many People | CC: | dbaio, dem.procopiou, swills, ultima | ||||||
| Priority: | --- | Keywords: | needs-qa | ||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Comment on attachment 184811 [details]
patch
You can set maintainer-approval to + on attachments for ports you are MAINTAINER of.
(In reply to Danilo G. Baio from comment #1) Ok, thanks for letting me know. Hi Demetris. I couldn't build it. Build logs are here: http://poudriere.bs2.com.br/poudriere/data/latest-per-pkg/gloox/1.0.20/ Could you take a look? Created attachment 185024 [details]
patch-fixed
updated patch
* Many patchfiles are only modifying date/time, please remove these patches.
* There are many patchfiles that are similar modifying the same thing. Instead of creating a patch for each, a REINPLACE_CMD should do the trick.
${REINPLACE_CMD} 's/<stdio.h>/<ctime>/ ; s/<locale.h>/<clocale>/' \
<tab> ${WRKSRC}/foo.h ${WRKSRC}/bar.h ... ... ...
Also add a comment on why these are being changed.
(In reply to Richard Gallamore from comment #5) I tend to prefer patches to REINPLACE_CMD where possible. Calling REINPLACE_CMD can break silently. Also, it makes it a lot harder to get changes upstream. A commit references this bug: Author: swills Date: Fri Aug 18 03:33:25 UTC 2017 New revision: 448205 URL: https://svnweb.freebsd.org/changeset/ports/448205 Log: net-im/gloox: Update to 1.0.20 PR: 221073 Submitted by: Demetris Procopiou <dem.procopiou@gmail.com> (maintainer) Changes: head/net-im/gloox/Makefile head/net-im/gloox/distinfo head/net-im/gloox/files/patch-src_examples_adhoc__example.cpp head/net-im/gloox/files/patch-src_examples_annotations__example.cpp head/net-im/gloox/files/patch-src_examples_bookmarkstorage__example.cpp head/net-im/gloox/files/patch-src_examples_component__example.cpp head/net-im/gloox/files/patch-src_examples_disco__example.cpp head/net-im/gloox/files/patch-src_examples_privacylist__example.cpp head/net-im/gloox/files/patch-src_examples_privatexml__example.cpp head/net-im/gloox/files/patch-src_examples_register__example.cpp head/net-im/gloox/files/patch-src_examples_reset__example.cpp head/net-im/gloox/files/patch-src_examples_roster__example.cpp head/net-im/gloox/files/patch-src_examples_vcard__example.cpp head/net-im/gloox/pkg-plist Committed, thanks! (In reply to Steve Wills from comment #6) Will be more considerate with patches in the future. |
Created attachment 184811 [details] patch - update to 1.0.20 - added some code patches - update pkg-plist