Bug 221098
| Summary: | [NEW PORT] science/Trilinos: Framework for solution for engineering and scientific problems | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Jesse Smith <jsmith> | ||||
| Component: | Individual Port(s) | Assignee: | Yuri Victorovich <yuri> | ||||
| Status: | Closed Overcome By Events | ||||||
| Severity: | Affects Only Me | CC: | betsanalizci, bozayimacun123, diizzy, koobs, mikegibson096, msaddkijalel, nafta0404, natetinor, prisinghkismis1998, raymond.reynoldssss, s.techmantra, vanajansr2, yuri | ||||
| Priority: | --- | Keywords: | feature, needs-patch, needs-qa | ||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback?
(jsmith) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://github.com/trilinos/Trilinos/ | ||||||
| Attachments: |
|
||||||
|
Description
Jesse Smith
2017-07-30 01:20:49 UTC
Thank you for fulfilling a WantedPorts request Please fix these errors: # portlint -A WARN: /usr/ports/science/trilinos/pkg-descr: includes lines that exceed 80 characters. FATAL: Makefile: [1]: incorrect header; use Created by: with a single space, then $FreeBSD$. WARN: Makefile: COMMENT is not supposed to begin with 'A ', 'An ', or 'The '. FATAL: Makefile: non-comment line in comment section. FATAL: Makefile: no $FreeBSD$ line in comment section. FATAL: Makefile: extra item "MAINTAINER" placed in the PORTNAME section. FATAL: Makefile: extra item "COMMENT" placed in the PORTNAME section. FATAL: Makefile: PORTNAME has to be there. WARN: Makefile: PORTVERSION/DISTVERSION is set externally to this port's Makefile, but this port is not configured as a slave port. WARN: Makefile: CATEGORIES is set externally to this port's Makefile, but this port is not configured as a slave port. FATAL: Makefile: extra item "LICENSE" placed in the MAINTAINER section. FATAL: Makefile: extra item "LICENSE_COMB" placed in the MAINTAINER section. WARN: Makefile: COMMENT is set externally to this port's Makefile, but this port is not configured as a slave port. FATAL: Makefile: extra item "USES" placed in the LICENSE section. FATAL: Makefile: extra item "CMAKE_ARGS" placed in the LICENSE section. WARN: Consider to set DEVELOPER=yes in /etc/make.conf 10 fatal errors and 6 warnings found. Also, please fix these errors: # make stage-qa ====> Running Q/A tests (stage-qa) Error: '/bin/bash' is an invalid shebang you need USES=shebangfix for 'bin/nvcc_wrapper' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'bin/phalanx_create_evaluator.py' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'lib/cmake/tribits/python_utils/gitdist.py' Error: '/usr/bin/env python' is an invalid shebang you need USES=shebangfix for 'lib/cmake/tribits/python_utils/snapshot-dir.py' *** Error code 1 Bash should be either made a RUN_DEPENDS, if it is essential, or replaced with /bin/sh if Bourne shell can run it. USE=python is missing. Please also determine is any python works, or only python3, or only python3. Also, why do you disable Fortran? (-DTrilinos_ENABLE_Fortran:BOOL=OFF) It should be made a port option. Same with Trilinos_ENABLE_OpenMP. Please make it build dynamic libraries along with, or instead of static ones. Dynamic libraries should be preferred. It fails to build in poudriere. Please always build ports in poudriere before submitting.[1] Poudriere fails to find x11, but stage-qa doesn't complain about x11. This is likely because their CMakeLists.txt requires it but doesn't actually use it, which is the bug in Trilinos if true. Upstream bugs need to be reported when found. [1] https://www.freebsd.org/doc/handbook/ports-poudriere.html batch change of PRs untouched in 2018 marked "in progress" back to open. I tried to make the port for the whole Trilinos, not just a ortion of it as the submitted patch did, and couldn't yet make the rest build. Will come back to it. MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM @Yuri Do we need anything from OP or anywhere else to progress this? MARKED AS SPAM @Jesse Are you able to provide an update to address comments (shared libraries and fixing build issues) MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM MARKED AS SPAM Closing this due lack of response/feedback, please open a new PR if this is still relevant. Trilinos is already in the tree: science/trilinos. Ahh, sorry for overlooking (In reply to Daniel Engberg from comment #26) No problem, Daniel! |
