Bug 221370
Created attachment 185232 [details]
The original shar had a minor error; this attachment is the corrected shar
Created attachment 185289 [details]
Improved the documentation in pkg-descr / --usage
pkg-descr includes a line about the postprocessor. The script's --usage function uses a backslash to esacpe the $ of $EDITOR.
Created attachment 185351 [details]
New shar containing 3 improvments as suggested by actual usage
Actual usage by an associate led to a few suggestions for improvement, which I entirely agreed with and have incorporated in the new shar being submitted :
1) A preview is first shown of what the stages are going to install. If the preview seems right to the user, actual installation then commences
2) User gets a chance to optionally pass --yes to 'pkg install' at runtime so that the stages get installed non-interactively
3) An additional command-line switch has been thrown in to let the user disable post-processing.
Thanks
Manish Jain
Created attachment 185443 [details]
Contains tar that holds updated shar + portlint log + poudriere log
Since I am a new port developer, I did not know how to write the Makefile correctly for portlint/poudriere. Have modified the Makefile so that portlint/poudriere run it clean. The tar contains the new shar, portlint log and poudriere log.
Created attachment 185448 [details]
Contains the shar for the new port mkdesktop with a minor correction
I noticed a small type error in the diagnostics section. I have corrected that. I am now uploading just the shar, rather than tar containing shar + logs. If you want the portlint/poudriere logs, please message me and I shall upload them too.
Created attachment 185449 [details]
Corrected shar with updated distinfo
The distinfo was unfortunately not updated in the previous upload. Am correcting that now.
Created attachment 185453 [details]
Contains shar with help-file corrected for very long lines
This look cool. I'v learned some new things just reading the script. I have a couple things I want to suggest.
First, I create a repository and start some version control. I recommend using git. It is a bit complex and difficult to use at first, but it pays off. Create a github account and add it there. On the port, add USE_GITHUB= yes with the required variables, usually being GH_ACCOUNT, and sometimes GH_PROJECT. This will fix most of the problems I see right now.
${PREFIX}/share/${PORTNAME}, this is the same as ${DATADIR}
Overall I like what you are doing, thanks for your contributions I look forward to testing. =]
Created attachment 185481 [details] Updated shar for the new port mkdesktop As suggested by Yuri Victorovich, have rectified Makefile : << You need to align all values at the level of 2 tabs. You need to make MASTER_SITES= DISTFILES= empty. No need for NO_WRKSUBDIR= >> Created attachment 185488 [details]
shar with minor update to Makefile
Makefile was referring to paths as files/ rather than ${FILESDIR}/
Created attachment 185514 [details]
shar updated with GitHub Makefile
Now GH is being used, thanks to Richard and Yuri
Created attachment 186298 [details]
mkdesktop script had 2 errors; now corrected
I came across 2 errors in mkdesktop in the post-processing for devfs.conf. I have corrected the script and made a couple of other improvements. The updated script has been uploaded to GH
Created attachment 186495 [details]
Output formatting improved to curb excess text per screen
With a couple of bug fixes and improved output formatting, the port version is herewith being up from 1.0 to 1.1
Created attachment 186514 [details]
Output formatting improved : inverse colours to underlined text
Stage names are now displayed underlined - visually better than the previous strategy of inverse colours
Created attachment 187213 [details]
shar with minor update to mkdesktop script
Spotted a couple of typos in shell script's LINENO handling. Version being bumped up to 1.6
A commit references this bug: Author: ultima Date: Wed Oct 25 03:01:57 UTC 2017 New revision: 452829 URL: https://svnweb.freebsd.org/changeset/ports/452829 Log: mkdesktop is a Bourne script that helps to standardize the process of FreeBSD desktop installation as much as possible per user, with plenty of flexibility as well as modularity. By default, you get 5 distinct stages for defining your desktop environment. But you can always add/subtract/customize the stages as much as you wish. Once you start using mkdesktop, you will pretty soon love it - particularly its post-processor which automatically kicks in once the stages have been processed - it sets up emulation layers and configuration of system files, if the user so desires. WWW: https://github.com/bourne-again/mkdesktop PR: 221370 Submitted by: born^@hotmail.com (maintainer) Changes: head/sysutils/Makefile head/sysutils/mkdesktop/ head/sysutils/mkdesktop/Makefile head/sysutils/mkdesktop/distinfo head/sysutils/mkdesktop/pkg-descr Had to make a few changes but its done. I removed the LICENSE because there is nothing indicating that is the correct license in the source. Please add the license in the source and readd it in a future release. Created attachment 193486 [details]
Updated port files for new release of mkdesktop
Since kde4 package names have changed (kde-baseapps -> kde-baseapps-kde4), mkdesktop needed to be updated. The shar contains the port files (Makefile + distinfo + pkg-descr) for updated mkdesktop
|
Created attachment 185207 [details] Contains the shar for the new port mkdesktop mkdesktop is a Bourne script that helps to standardize the process of FreeBSD desktop installation as much as possible per user, with plenty of flexibility as well as modularity. By default, you get 5 distinct stages for defining your desktop environment. But you can always add/subtract/customize the stages as much as you wish. Once you start using mkdesktop, you will pretty soon love it.