Bug 221391
| Summary: | graphics/zbar can work with ImageMagick-7 just as well | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mikhail T. <freebsd-2024> | ||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | dev2, lantw44, pi, vvd, w.schwarzenfeld | ||||||||
| Priority: | --- | Flags: | dev2:
maintainer-feedback+
|
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Mikhail T.
2017-08-10 15:00:13 UTC
I'm updating my Poudriere VM to test this patch. As a matter of principle I have no objection, but I'd like to have some testing done (both technical and functional) before it gets committed. I've stumbled upon a problem with this. Using the samen command on a couple of example pics, I get ###################################### # with ImageMagick6 and current zbar # ###################################### EAN-8.jpg: EAN-8:50184385 UPC-A.png: EAN-13:0036000291452 barcode.png: EAN-13:9876543210128 code128.png: CODE-128:010123456789012815051231 code39.png: CODE-39:123ABC ean-13.jpg: EAN-13:7612345000121 interleaved2of5.png: I2/5:12345678 upc-e.gif: EAN-13:0012345000065 ######################################## # with ImageMagick6 and proposed patch # ######################################## EAN-8.jpg: ERROR: unable to open image `EAN-8.jpg': No such file or directory @ error/blob.c/OpenBlob/2701 UPC-A.png: ERROR: unable to open image `UPC-A.png': No such file or directory @ error/blob.c/OpenBlob/2701 barcode.png: ERROR: unable to open image `barcode.png': No such file or directory @ error/blob.c/OpenBlob/2701 code128.png: ERROR: unable to open image `code128.png': No such file or directory @ error/blob.c/OpenBlob/2701 code39.png: ERROR: unable to open image `code39.png': No such file or directory @ error/blob.c/OpenBlob/2701 ean-13.jpg: ERROR: unable to open image `ean-13.jpg': No such file or directory @ error/blob.c/OpenBlob/2701 interleaved2of5.png: ERROR: unable to open image `interleaved2of5.png': No such file or directory @ error/blob.c/OpenBlob/2701 upc-e.gif: ERROR: unable to open image `upc-e.gif': No such file or directory @ error/blob.c/OpenBlob/2701 I have yet to try ImageMagick7 and the proposed patch, but at present I would advise against committing these changes. (In reply to Oliver Heesakkers from comment #2) > Using the samen command on a couple of example pics Could you post the actual command-line you've used, please? Thank you! fsck found some issues with the root partition of my Poudriere VM. All tests successful. Feel free to commit. Thanks for the patch! Committed, thanks! A commit references this bug: Author: pi Date: Mon Jan 7 19:39:37 UTC 2019 New revision: 489610 URL: https://svnweb.freebsd.org/changeset/ports/489610 Log: graphics/zbar: work with ImageMagick-7 instead of -6 PR: 221391 Submitted by: Mikhail T. <mi@ALDAN.algebra.com> Approved by: Oliver Heesakkers <dev2@heesakkers.info> (maintainer) Changes: head/graphics/zbar/Makefile head/graphics/zbar/files/patch-configure head/graphics/zbar/files/patch-zbarimg.c (In reply to commit-hook from comment #6) > graphics/zbar: work with ImageMagick-7 instead of -6 Why?! ImageMagick-7 can't be installed together with ImageMagick-6, but most other ports can work with ImageMagick-6 only. And now you can't install zbar on most real systems. 1) Option ImageMagick-6 or 7 for zbar; 2) But better to do possible to install ImageMagick-6 and 7 together. So we need an option to allow to select the version, and 6 should be the default? The patch enables you to use 7, it does not force it upon you (unless there's a bug in the patch) Can you, please, show how to build zbar with ImageMagick 6 after this patch? Created attachment 200964 [details]
patch-selectable-imagick-version
This patch adds a radio option to select either version 6 or 7 of ImageMagick. Default will be 7.
The problem with the previous patch was that the LIB_DEPEND only works
if the build is not via poudriere and the user built IM6 before.
Hmm, test with V6 selected fails in pkg-plist 8-( Created attachment 200965 [details]
patch-selectable-imagick-version
This should work in all cases: either v6 or v7, or none. And even if one of the imagemagick versions is installed and none is selected and it is build outside poudriere, then no im-version is used.
A commit references this bug: Author: pi Date: Sun Jan 27 10:42:25 UTC 2019 New revision: 491340 URL: https://svnweb.freebsd.org/changeset/ports/491340 Log: graphics/zbar: make the ImageMagick an option, 7 the default PR: 221391 Reported by: vvd@unislabs.com Approved by: dev2@heesakkers.info (maintainer timeout) Changes: head/graphics/zbar/Makefile head/graphics/zbar/files/patch-Makefile.in head/graphics/zbar/files/patch-configure head/graphics/zbar/files/patch-zbarimg.c head/graphics/zbar/files/patch-zbarimg_zbarimg.c head/graphics/zbar/pkg-plist 6 have to be default yet. For example graphics/inkscape mandatory depends on libMagick++-6.so:graphics/ImageMagick6. Is there anything to do here, or could it be closed? As far as the ImageMagick discussion was concerned, yeah this could be closed. Looking at the Makefile, the QT4 option should likely be removed now, I know I'm not going to port it to QT5. But it's cleaner to do this in different PR, so yeah, just close it. I'll make another PR to remove the QT4 bits. (In reply to Walter Schwarzenfeld from comment #16) As I said before: 6 have to be default for all ports yet. Close here, see comment17. (In reply to Walter Schwarzenfeld from comment #19) Not important for me - I'm build all software from ports self with custom options, but who use packages can't install graphics/inkscape and graphics/zbar on same host: graphics/ImageMagick6 conflicts with graphics/ImageMagick7. But the conflict will be another new PR. |
