Bug 22152

Summary: typo in ip_fw.c
Product: Base System Reporter: Bernard Steiner <bs>
Component: kernAssignee: Luigi Rizzo <luigi>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.1-RELEASE   
Hardware: Any   
OS: Any   

Description Bernard Steiner 2000-10-20 16:30:01 UTC
	
/sys/netinet/ip_fw.c about line 175 in 4.1R, 4.1.1R
(and possibly 5.0 current ?) contain the line

SYSCTL_INT(_net_inet_ip_fw, OID_AUTO, dyn_short_lifetime, CTLFLAG_RW,
/*  --------------------------------------^^^^^ */
    &dyn_rst_lifetime, 0, "Lifetime of dyn. rules for other situations");
/*  -----^^^ */

which I believe makes the dynamic ruleset time out pre-maturely.

Fix: 

Looks like a cut-and-paste typo to me. I suggest:

SYSCTL_INT(_net_inet_ip_fw, OID_AUTO, dyn_short_lifetime, CTLFLAG_RW,
    &dyn_short_lifetime, 0, "Lifetime of dyn. rules for other situations");
/*  -----^^^^^ */

but please do check that I am not mistaken :-)
Comment 1 ru freebsd_committer freebsd_triage 2000-10-20 19:05:10 UTC
Responsible Changed
From-To: freebsd-bugs->luigi

Over to the inventor.
Comment 2 Luigi Rizzo freebsd_committer freebsd_triage 2000-10-26 01:26:07 UTC
State Changed
From-To: open->closed

applied proposed fix (same as PR19511)