Bug 221634
| Summary: | textproc/expat2: update to 2.2.3 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Don Lewis <truckman> | ||||||||
| Component: | Individual Port(s) | Assignee: | Adam Weinberger <adamw> | ||||||||
| Status: | Closed FIXED | ||||||||||
| Severity: | Affects Some People | CC: | adamw, kuriyama, svysh.fbsd | ||||||||
| Priority: | --- | Keywords: | patch | ||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(kuriyama) antoine: exp-run+ |
||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 187607 [details] patch to update 2.2.1 --> 2.2.4 - patch to update 2.2.1 --> 2.2.4 Changes: https://github.com/libexpat/libexpat/blob/R_2_2_4/expat/Changes - "portlint -AC" just warns about non-empty $FreeBSD$ tag. - Tested at 11.1-release-amd64 with poudriere 3.1.99.20171028 and perl5-5.24.3 - This patch takes distribution of expat2 from SF. I you opt to take distribution form GH instead, then you face cyclic dependency between this port and textproc/docbook2X. The reason is: Distribution from SF contains docs of expat2 in UNIX man format, while distribution from GH contains docs of expat2 in docbook format, and expat2 is need to prepare the man. Created attachment 188863 [details] patch to update 2.2.1 --> 2.2.5 - update 2.2.1 --> 2.2.5 Changes: https://github.com/libexpat/libexpat/blob/R_2_2_5/expat/Changes - add install-strip - switch to GH distribution. - "portlint -AC" just warns about non-empty $FreeBSD$ tag. - testport of poudriere 3.2.99.20171213 at 11.1-release-amd64 with perl 5.24.3 runs ok. - I could take maintainership (not included in the patch) if needed. ================================================ The proposed patch takes handmade distribution tarball (let us call it H-tarball) provided for a release on GH. This H-tarball is essentially different from the sources checked-out from GH. The latter being identical to the autogenerated tarball (let us call it A-tarball), which we would get if using USE_GITHUB construct in the port's Makefile. H-tarball contains files, which are missing from the A-tarball, such as: - configure script, - several Makefile's - documentation prebuilt from several formats To build documentation from A-tarball, it would require this very expat to be installed in advance, thus bringing us to the cycle dependency. No wonder that the author of expat went into trouble and provided the H-tarball. Hence, building from A-tarball would be a challenging task, which goes far beyond saying "USES=autoreconf gmake" and "GNU_CONFIGURE=yes". For the textproc/expat2 ver. 2.5.5: H-tarball: https://github.com/libexpat/libexpat/releases/download/R_2_2_5/expat-2.2.5.tar.bz2 source: https://github.com/libexpat/libexpat/tree/master/expat A-tarball: https://codeload.github.com/libexpat/libexpat/tar.gz/R_2_2_5?dummy=/R_2_2_5_GH0.tar.bz2 Also, this project has declared that it moves from SF to GH. It still publishes H-tarballs on SF. But it seems that switching of the FreeBSD port such that it takes distribution from GH is inevitable. This port clearly needs a new maintainer. truckman or Sergei, do either of you want to take over maintainership? A tremendous number of ports depend on expat2. We should do an exp-run to be safe here. Adam, Thank you, yes, I am ready to take m13p, as already offered to in Comment 2 above. Regards, Sergei Exp-run looks fine. Adam, Do you think that the case of non-standard (H-tarballs) distribution from GH should be addressed 1) in bsd.sites.mk 2) in Porter's Handbook Can I prepare patches for theese, or only special people do it? Regards, Sergei (In reply to Sergei Vyshenski from comment #7) By all means, please do make patches for anything that seems sub-optimal or confusing! A commit references this bug: Author: adamw Date: Wed Dec 20 19:58:13 UTC 2017 New revision: 456847 URL: https://svnweb.freebsd.org/changeset/ports/456847 Log: Update to 2.2.5. Submitter becomes maintainer after consecutive and lengthy timeouts. PR: 221634 Submitted by: svysh.fbsd@gmail.com Approved by: maintainer timeout (4 months) Exp-run by: antoine Changes: head/textproc/expat2/Makefile head/textproc/expat2/distinfo head/textproc/expat2/pkg-descr head/textproc/expat2/pkg-plist Committed. Thanks for your work and your patience, Sergei! |
Created attachment 185580 [details] patch to upgrade expat2 to version 2.2.3