Bug 221751

Summary:

[PATCH] devel/libgtop example depends on obsolete sbrk()

Product:

Ports & Packages

Reporter:

Brooks Davis <brooks>

Component:

Individual Port(s)

Assignee:

freebsd-gnome (Nobody) <gnome>

Status:

Closed FIXED

Severity:

Affects Some People

CC:

Andrew

Priority:

---

Keywords:

patch

Version:

Latest

Flags:

bugzilla: maintainer-feedback? (gnome)

Hardware:

arm64

OS:

Any

Attachments:

Description	Flags
patch	none

Description Brooks Davis freebsd_committer

2017-08-23 22:59:52 UTC

libgtop is the top blocker on https://wiki.freebsd.org/PortsBrokenWithSbrk.  It's broken because an example uses some sbrk(0) calls as an unreliable and non-portable way to demonstrate memory utilization.  The attached patch removes them as they are pointless and likely wrong in practice.  This should allow libgtop to build and arm64 and riscv.

Comment 1 Brooks Davis freebsd_committer

2017-08-24 18:47:13 UTC

Created attachment 185725 [details]
patch

Comment 2 commit-hook freebsd_committer

2017-09-25 19:27:19 UTC

A commit references this bug:

Author: kwm
Date: Mon Sep 25 19:27:05 UTC 2017
New revision: 450629
URL: https://svnweb.freebsd.org/changeset/ports/450629

Log:
  Allow to build on arm64 and riscv by removing the usage of sbrk(2), which
  doesn't exist on arm64 and riscv.

  PR:		221751
  Submitted by:	brooks@

Changes:
  head/devel/libgtop/files/patch-examples_mountlist.c